[ 
https://issues.apache.org/jira/browse/CASSANDRA-13855?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829689#comment-17829689
 ] 

Maxim Muzafarov commented on CASSANDRA-13855:
---------------------------------------------

Hey,

I've checked the implementation and I'd like to throw a new idea on the table. 
I have nothing against the HttpSeedProvider itself, but I guess for the end 
user it is more interesting to have cloud-related stuff that they are already 
configured with (the same as we provide for the snitches - Azure, EC2, Google).

Here are the SeedProviders that can be found on the GitHub:
https://github.com/search?q=SeedProvider&type=repositories

So, I guess we don't need to create a parallel hierarchy of classes for the 
SeedProvider interface and can do the following:
# Either extend the IEndpointSnitch or create a new interface new a new :
{code}
    public String getRack(InetAddressAndPort endpoint);
    public String getDatacenter(InetAddressAndPort endpoint);
    /** {@code true} if the endpoint is the seed node. */
    default public boolean isSeed(InetAddressAndPort endpoint) {};
{code} 
# Implement a new {{isSeed}} method for each cloud adapter we are interested in 
e.g. EC2, Azure, Google etc. that fetches the seed status from a tag.
https://github.com/kryptnostic/ec2-cassandra-seedprovider/blob/master/src/main/java/com/kryptnostic/Ec2SeedProvider.java#L35
# Create a new adapter that implements the SeedProvider interface and wraps the 
{{IEndpointSnitch}} e.g. new CloudSeedProvider(IEndpointSnitch snitch). 

WDYT?

> Implement Http Seed provider
> ----------------------------
>
>                 Key: CASSANDRA-13855
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13855
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Legacy/Coordination, Legacy/Core
>            Reporter: Jon Haddad
>            Assignee: Claude Warren
>            Priority: Low
>              Labels: lhf
>             Fix For: 5.x
>
>         Attachments: 0001-Add-URL-Seed-Provider-trunk.txt, signature.asc, 
> signature.asc, signature.asc
>
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Seems like including a dead simple seed provider that can fetch from a URL, 1 
> line per seed, would be useful.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to