[ https://issues.apache.org/jira/browse/CASSANDRA-19130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17829889#comment-17829889 ]
Stefan Miklosovic commented on CASSANDRA-19130: ----------------------------------------------- When it comes to {code} if (tableMetadata.isVirtual()) return executeLocally(state, options); {code} This will not work in TCM because virtual table is not distributed so there is basically nothing to commit into TCM and I just return there instantly. The truncation against vtables is done only against the implementations of AbstractMutableVirtualTable-s and they are not covered by TCM, each vtable is just a local one, so committing anything does not make sense, no? I am not sure how to solve that blocking truncation ... Any ideas? But when I step aside there for a while, is this really what we want to do? Truncations committed to TCM? Currently, all nodes need to be up, as already described in the description, so here we are moving away from that? I would like to have that confirmed. > Implement transactional table truncation > ---------------------------------------- > > Key: CASSANDRA-19130 > URL: https://issues.apache.org/jira/browse/CASSANDRA-19130 > Project: Cassandra > Issue Type: New Feature > Components: Consistency/Coordination > Reporter: Marcus Eriksson > Assignee: Stefan Miklosovic > Priority: Normal > Fix For: 5.x > > Time Spent: 10m > Remaining Estimate: 0h > > TRUNCATE table should leverage cluster metadata to ensure consistent > truncation timestamps across all replicas. The current implementation depends > on all nodes being available, but this could be reimplemented as a > {{Transformation}}. -- This message was sent by Atlassian Jira (v8.20.10#820010) --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org