JeetKunDoug commented on code in PR #45:
URL:
https://github.com/apache/cassandra-analytics/pull/45#discussion_r1539956682
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/bulkwriter/CqlTableInfoProvider.java:
##########
@@ -98,9 +98,20 @@ public CqlField.CqlType getColumnType(String columnName)
@Override
public List<ColumnType<?>> getPartitionKeyTypes()
{
- return cqlTable.partitionKeys().stream()
- .map(cqlField ->
DATA_TYPES.get(cqlField.type().cqlName().toLowerCase()))
- .collect(Collectors.toList());
+ List<ColumnType<?>> types = cqlTable.partitionKeys().stream()
+ .map(cqlField -> {
+ String typeName =
cqlField.type().cqlName().toLowerCase();
Review Comment:
Note that this map (`DATA_TYPES`) currently doesn't support UDTs at all -
it's something we need to implement separately to support UDTs for
partition/clustering key columns (as `Tokenizer` doesn't support them at this
time). So, for now, we throw if we can't find the type in that map, but we'll
need to update the logic once the Tokenizer supports them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
