absurdfarce commented on code in PR #1923:
URL:
https://github.com/apache/cassandra-java-driver/pull/1923#discussion_r1544088216
##########
Jenkinsfile:
##########
@@ -115,7 +109,12 @@ def buildDriver(jabbaVersion) {
}
def executeTests() {
- sh label: 'Execute tests', script: '''#!/bin/bash -le
+ def testJavaHome = sh(label: 'Get TEST_JAVA_HOME',script: '''#!/bin/bash -le
+ . ${JABBA_SHELL}
+ jabba which ${JABBA_VERSION}''', returnStdout: true).trim()
+ def testJavaVersion = (JABBA_VERSION =~ /.*\.(\d+)/)[0][1]
Review Comment:
There wasn't any reason to do this via a shell op; it's just a regex eval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
