[ 
https://issues.apache.org/jira/browse/CASSANDRA-19428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17833767#comment-17833767
 ] 

Ekaterina Dimitrova commented on CASSANDRA-19428:
-------------------------------------------------

I cannot reproduce the failures with or without the patch. Those tests are 
added to trunk with TCM, so I am not worried we could have broken them with 
this SAI patch. 

I will commit the current patch and open follow-up tickets for 
test_simple_decommission, testMixedVersionBlockDecom, testIncompleteState.

Test_simple_decommission actually fails in a different way locally, both with 
trunk and the current patch:

 
{code:java}
test_simple_decommission failed; it passed 0 out of the required 1 times.
 <class 'ccmlib.node.ToolError'>
 Subprocess ['nodetool', '-h', 'localhost', '-p', '7200', 'decommission'] 
exited with non-zero status; exit status: 1; 
stdout: nodetool: Can not commit transformation: "INVALID"(Not enough live 
nodes to maintain replication factor after decommission.).
See 'nodetool help' or 'nodetool help <command>'.
{code}
Committed:

To https://github.com/apache/cassandra.git

   973aad7b68..b0150e86fb  cassandra-5.0 -> cassandra-5.0

   2944d77aac..a1b0a310ed  trunk -> trunk

 

> Clean up KeyRangeIterator classes
> ---------------------------------
>
>                 Key: CASSANDRA-19428
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19428
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Feature/2i Index
>            Reporter: Ekaterina Dimitrova
>            Assignee: Ekaterina Dimitrova
>            Priority: Normal
>             Fix For: 5.0-rc, 5.x
>
>         Attachments: 
> Make_sure_the_builders_attach_the_onClose_hook_when_there_is_only_a_single_sub-iterator.patch
>
>          Time Spent: 3h
>  Remaining Estimate: 0h
>
> Remove KeyRangeIterator.current and simplify



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to