[
https://issues.apache.org/jira/browse/CASSANDRA-19556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17842576#comment-17842576
]
Yuqi Yan edited comment on CASSANDRA-19556 at 5/1/24 7:49 AM:
--------------------------------------------------------------
okay I just realized there is a similar feature already added in 5.0:
https://issues.apache.org/jira/browse/CASSANDRA-17495
The implementation was also adding these check for few subclasses in
AlterTableStatement in apply(). I guess with 17495 we don't need DDL guardrail,
but still we can have this DCL guardrail. wdyt? [~smiklosovic]
was (Author: JIRAUSER301388):
okay I just realized there is a similar feature already added in 5.0:
https://issues.apache.org/jira/browse/CASSANDRA-17495
The implementation was also adding these check for these statements. I guess
with 17495 we don't need DDL guardrail, but still we can have this DCL
guardrail. wdyt? [~smiklosovic]
> Guardrail to block DDL/DCL queries
> ----------------------------------
>
> Key: CASSANDRA-19556
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19556
> Project: Cassandra
> Issue Type: New Feature
> Components: Feature/Guardrails
> Reporter: Yuqi Yan
> Assignee: Yuqi Yan
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Sometimes we want to block DDL/DCL queries to stop new schemas being created
> or roles created. (e.g. when doing live-upgrade)
> For DDL guardrail current implementation won't block the query if it's no-op
> (e.g. CREATE TABLE...IF NOT EXISTS, but table already exists, etc. The
> guardrail check is added in apply() right after all the existence check)
> I don't have preference on either block every DDL query or check whether if
> it's no-op here. Just we have some users always run CREATE..IF NOT EXISTS..
> at startup, which is no-op but will be blocked by this guardrail and failed
> to start.
>
> 4.1 PR: [https://github.com/apache/cassandra/pull/3248]
> trunk PR: [https://github.com/apache/cassandra/pull/3275]
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
