frankgh commented on code in PR #59:
URL:
https://github.com/apache/cassandra-analytics/pull/59#discussion_r1597632737
##########
cassandra-analytics-integration-framework/src/main/java/org/apache/cassandra/sidecar/testing/SharedClusterIntegrationTestBase.java:
##########
@@ -428,9 +436,11 @@ protected Object[][] queryAllData(QualifiedName table)
* @param consistencyLevel the consistency level to use for querying the
data
* @return all the data queried from the table
*/
- protected Object[][] queryAllData(QualifiedName table, ConsistencyLevel
consistencyLevel)
+ protected Object[][] queryAllData(QualifiedName table, String
consistencyLevel)
Review Comment:
The main reason to use String here is convenience. At
`org.apache.cassandra.sidecar.testing.SharedClusterIntegrationTestBase` we use
type `org.apache.cassandra.distributed.api.ConsistencyLevel`, but at the call
sites we have other types available. In this case, we have type
`com.datastax.driver.core.ConsistencyLevel` from the
`org.apache.cassandra.analytics.TestConsistencyLevel`. Alternatively we can try
to consolidate into a single CL type that we use across all of the tests. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
