[
https://issues.apache.org/jira/browse/CASSANDRA-19632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849220#comment-17849220
]
Stefan Miklosovic commented on CASSANDRA-19632:
-----------------------------------------------
Looks fine, I think that cqlsh_tests.test_cqlsh.TestCqlsh test_describe is the
result of CASSANDRA-19592 and this build was not rebased againt the current
trunk
[CASSANDRA-19632-2|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19632-2]
{noformat}
java17_pre-commit_tests
✓ j17_build 5m 12s
✓ j17_cqlsh_dtests_py311_vnode 7m 45s
✓ j17_cqlsh_dtests_py38 6m 56s
✓ j17_cqlsh_dtests_py38_vnode 7m 20s
✓ j17_cqlshlib_cython_tests 9m 35s
✓ j17_cqlshlib_tests 9m 30s
✓ j17_dtests 35m 34s
✓ j17_dtests_vnode 36m 38s
✓ j17_jvm_dtests_latest_vnode 20m 44s
✓ j17_unit_tests 14m 15s
✓ j17_utests_latest 14m 27s
✓ j17_utests_oa 14m 21s
✕ j17_cqlsh_dtests_py311 6m 41s
cqlsh_tests.test_cqlsh.TestCqlsh test_describe
✕ j17_dtests_latest 36m 44s
auth_test.TestAuthUnavailable test_authorization_handle_unavailable
configuration_test.TestConfiguration test_change_durable_writes
✕ j17_jvm_dtests 22m 46s
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4344/workflows/f9410f3a-9af4-4924-a2c8-44fc3d7384c0]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4344/workflows/5a2470b3-7dee-4b50-98c7-1a5f9b50e650]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4344/workflows/7263d3ca-ef7f-4499-9fff-fbb77617b613]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4344/workflows/91f98de5-c3e5-45bb-9737-a6d98922fedf]
> wrap tracing logs in isTraceEnabled across the codebase
> -------------------------------------------------------
>
> Key: CASSANDRA-19632
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19632
> Project: Cassandra
> Issue Type: Improvement
> Components: Legacy/Core
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Our usage of logger.isTraceEnabled across the codebase is inconsistent. This
> would also fix issues similar in e.g. CASSANDRA-19429 as [~rustyrazorblade]
> suggested.
> We should fix this at least in trunk and 5.0 (not critical though) and
> probably come up with a checkstyle rule to prevent not calling isTraceEnabled
> while logging with TRACE level.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
