[
https://issues.apache.org/jira/browse/CASSANDRA-19158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17849992#comment-17849992
]
Sam Tunnicliffe commented on CASSANDRA-19158:
---------------------------------------------
The latest round of changes LGTM, but I think you missed the minor things (out
of date comments / double {{;;}} etc) on {{EpochAwareDebounce.java}}. Other
than that, I'm +1.
We talked offline about the test failure and identified that it's actually a
problem with the test, which needs updating since it predates automatic retry
of failed commits. We'll open a separate JIRA for that.
> Reuse native transport-driven futures in Debounce
> -------------------------------------------------
>
> Key: CASSANDRA-19158
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19158
> Project: Cassandra
> Issue Type: Improvement
> Components: Transactional Cluster Metadata
> Reporter: Alex Petrov
> Assignee: Alex Petrov
> Priority: Normal
> Attachments: ci_summary-1.html, ci_summary-2.html, ci_summary.html
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Currently, we create a future in Debounce, then create one more future in
> RemoteProcessor#sendWithCallback. This is further exacerbated by chaining
> calls, when we first attempt to catch up from peer, and then from CMS.
> First of all, we should always only use a native transport timeout driven
> futures returned from sendWithCallback, since they implement reasonable
> retries under the hood, and are easy to bulk-configure (ie you can simply
> change timeout in yaml and have all futures change their behaviour).
> Second, we should _chain_ futures and use map or andThen for fallback
> operations such as trying to catch up from CMS after an unsuccesful attemp to
> catch up from peer.
> This should significantly simplify the code and number of blocked/waiting
> threads.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
