absurdfarce commented on code in PR #1934: URL: https://github.com/apache/cassandra-java-driver/pull/1934#discussion_r1617689369
########## integration-tests/src/test/java/com/datastax/oss/driver/mapper/DeleteReactiveIT.java: ########## @@ -34,23 +34,27 @@ import com.datastax.oss.driver.api.mapper.annotations.Mapper; import com.datastax.oss.driver.api.mapper.annotations.Select; import com.datastax.oss.driver.api.mapper.entity.saving.NullSavingStrategy; -import com.datastax.oss.driver.api.testinfra.ccm.CcmRule; +import com.datastax.oss.driver.api.testinfra.ccm.CustomCcmRule; +import com.datastax.oss.driver.api.testinfra.requirement.BackendRequirement; +import com.datastax.oss.driver.api.testinfra.requirement.BackendType; import com.datastax.oss.driver.api.testinfra.session.SessionRule; -import com.datastax.oss.driver.categories.ParallelizableTests; import io.reactivex.Flowable; import java.util.UUID; import org.junit.Before; import org.junit.BeforeClass; import org.junit.ClassRule; import org.junit.Test; -import org.junit.experimental.categories.Category; import org.junit.rules.RuleChain; import org.junit.rules.TestRule; -@Category(ParallelizableTests.class) +// Do not run LWT tests in parallel because they may interfere. Tests operate on the same row. +@BackendRequirement( + type = BackendType.CASSANDRA, + description = "SASI indexes broken in DSE. See InventoryITBase#BROKEN_SASI_VERSION.") Review Comment: I think this is too strong a constraint. IIRC SASI indexes were borked in a specific DSE release. [The commit](https://github.com/apache/cassandra-java-driver/commit/c94e39c6ef8b45259a38b7e4a9191f40472e193d) which introduced BROKEN_SASI_VERSION has a lot of useful context here, specifically the definition of [isSasiBroken()](https://github.com/apache/cassandra-java-driver/blob/4.x/integration-tests/src/test/java/com/datastax/oss/driver/mapper/InventoryITBase.java#L95-L99) which checks for an exact DSE version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
