[
https://issues.apache.org/jira/browse/CASSANDRA-12937?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17850195#comment-17850195
]
Stefan Miklosovic edited comment on CASSANDRA-12937 at 5/28/24 10:12 PM:
-------------------------------------------------------------------------
I've hardened the path little bit and added few tests.
[CASSANDRA-12937-squashed|https://github.com/instaclustr/cassandra/tree/CASSANDRA-12937-squashed]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 3s
✓ j17_cqlsh_dtests_py311 7m 13s
✓ j17_cqlsh_dtests_py311_vnode 7m 37s
✓ j17_cqlsh_dtests_py38 6m 52s
✓ j17_cqlsh_dtests_py38_vnode 7m 21s
✓ j17_cqlshlib_cython_tests 7m 56s
✓ j17_cqlshlib_tests 6m 46s
✓ j17_jvm_dtests_latest_vnode 27m 54s
✓ j17_unit_tests 14m 44s
✓ j17_utests_latest 15m 3s
✕ j17_dtests 37m 42s
scrub_test.TestScrub test_standalone_scrub_essential_files_only
topology_test.TestTopology test_movement
✕ j17_dtests_latest 35m 24s
offline_tools_test.TestOfflineTools test_sstableverify
scrub_test.TestScrub test_standalone_scrub_essential_files_only
✕ j17_dtests_vnode 36m 15s
scrub_test.TestScrub test_standalone_scrub_essential_files_only
✕ j17_jvm_dtests 29m 10s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testOptionalMtlsModeDoNotAllowNonSSLConnections
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testEndpointVerificationEnabledIpNotInSAN
✕ j17_utests_oa 17m 8s
org.apache.cassandra.db.compaction.CompactionStrategyManagerTest
testAutomaticUpgradeConcurrency
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/9fbc3590-1168-41f8-a7c8-a3fbb3dfc0b0]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/d2e65942-b99e-4927-bd65-85800e9d94e9]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/df51197e-c92e-454f-9c75-2f5eaee43bb8]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/6df36e29-d2cd-4838-b3b8-69e9113b295f]
was (Author: smiklosovic):
[CASSANDRA-12937-squashed|https://github.com/instaclustr/cassandra/tree/CASSANDRA-12937-squashed]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 3s
✓ j17_cqlsh_dtests_py311 7m 13s
✓ j17_cqlsh_dtests_py311_vnode 7m 37s
✓ j17_cqlsh_dtests_py38 6m 52s
✓ j17_cqlsh_dtests_py38_vnode 7m 21s
✓ j17_cqlshlib_cython_tests 7m 56s
✓ j17_cqlshlib_tests 6m 46s
✓ j17_jvm_dtests_latest_vnode 27m 54s
✓ j17_unit_tests 14m 44s
✓ j17_utests_latest 15m 3s
✕ j17_dtests 37m 42s
scrub_test.TestScrub test_standalone_scrub_essential_files_only
topology_test.TestTopology test_movement
✕ j17_dtests_latest 35m 24s
offline_tools_test.TestOfflineTools test_sstableverify
scrub_test.TestScrub test_standalone_scrub_essential_files_only
✕ j17_dtests_vnode 36m 15s
scrub_test.TestScrub test_standalone_scrub_essential_files_only
✕ j17_jvm_dtests 29m 10s
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testOptionalMtlsModeDoNotAllowNonSSLConnections
org.apache.cassandra.distributed.test.NativeTransportEncryptionOptionsTest
testEndpointVerificationEnabledIpNotInSAN
✕ j17_utests_oa 17m 8s
org.apache.cassandra.db.compaction.CompactionStrategyManagerTest
testAutomaticUpgradeConcurrency
java17_separate_tests
java11_pre-commit_tests
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/9fbc3590-1168-41f8-a7c8-a3fbb3dfc0b0]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/d2e65942-b99e-4927-bd65-85800e9d94e9]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/df51197e-c92e-454f-9c75-2f5eaee43bb8]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4358/workflows/6df36e29-d2cd-4838-b3b8-69e9113b295f]
> Default setting (yaml) for SSTable compression
> ----------------------------------------------
>
> Key: CASSANDRA-12937
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12937
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Config
> Reporter: Michael Semb Wever
> Assignee: Stefan Miklosovic
> Priority: Low
> Labels: AdventCalendar2021
> Fix For: 5.x
>
> Time Spent: 8h 20m
> Remaining Estimate: 0h
>
> In many situations the choice of compression for sstables is more relevant to
> the disks attached than to the schema and data.
> This issue is to add to cassandra.yaml a default value for sstable
> compression that new tables will inherit (instead of the defaults found in
> {{CompressionParams.DEFAULT}}.
> Examples where this can be relevant are filesystems that do on-the-fly
> compression (btrfs, zfs) or specific disk configurations or even specific C*
> versions (see CASSANDRA-10995 ).
> +Additional information for newcomers+
> Some new fields need to be added to {{cassandra.yaml}} to allow specifying
> the field required for defining the default compression parameters. In
> {{DatabaseDescriptor}} a new {{CompressionParams}} field should be added for
> the default compression. This field should be initialized in
> {{DatabaseDescriptor.applySimpleConfig()}}. At the different places where
> {{CompressionParams.DEFAULT}} was used the code should call
> {{DatabaseDescriptor#getDefaultCompressionParams}} that should return some
> copy of configured {{CompressionParams}}.
> Some unit test using {{OverrideConfigurationLoader}} should be used to test
> that the table schema use the new default when a new table is created (see
> CreateTest for some example).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
