[
https://issues.apache.org/jira/browse/CASSANDRA-19671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17852341#comment-17852341
]
Arun Ganesh commented on CASSANDRA-19671:
-----------------------------------------
[~bschoeni], sure. I'll add them.
[~smiklosovic], when I was looking at the current unit-tests, I found
something. {{TableStatsPrinterTest::testDefaultHumanReadablePrinter}} doesn't
seem to be testing the human-readable formatting logic in its entirety. Some of
this formatting happens inside
[initializeKeyspaces()|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java#L179],
and it is not called when we use a {{TestTableStatsHolder}} (see
[here|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java#L55]).
I believe this has to do with how we store metrics when we retrieve them from
the probe: directly store them into StatsTable formatted as strings (like
{{[spaceUsedLive|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsHolder.java#L300]}})
vs keep them as numbers, format them when we print them (like
{{[bytesRepaired|https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/tools/nodetool/stats/TableStatsPrinter.java#L125]}}).
> Nodetool tabestats: add keyspace space used and table r/w ratio
> ---------------------------------------------------------------
>
> Key: CASSANDRA-19671
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19671
> Project: Cassandra
> Issue Type: Improvement
> Components: Tool/nodetool
> Reporter: Brad Schoening
> Assignee: Arun Ganesh
> Priority: Low
> Attachments: plaintext-humanreadable.txt, plaintext.txt
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Nodetool tabestats reports the space used live and total per table, but not
> for the entire keyspace. This would be useful information.
> Also, in the table level stats, it would be useful to have the read/write
> ratio. This metric is important in choosing compaction strategies such as
> LCS.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
