[
https://issues.apache.org/jira/browse/CASSANDRA-19677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17864323#comment-17864323
]
Jordan West commented on CASSANDRA-19677:
-----------------------------------------
I am +1 on the patch as written in terms of the code. I have some concerns
about the number of settings / noise this patch introduces. As discussed with
[~bbotella] we plan to bring that discussion to the mailing list. If the
community decides to move forward, this code is ready to merge.
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/jrwest/cassandra/189/workflows/de606ec3-0787-455f-acab-1c1dc05ba714]
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/jrwest/cassandra/189/workflows/8360a655-08d2-4763-82d2-59e48089cbcc]
> Add per type max size guardrails
> --------------------------------
>
> Key: CASSANDRA-19677
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19677
> Project: Cassandra
> Issue Type: Improvement
> Components: Feature/Guardrails
> Reporter: Bernardo Botella
> Assignee: Bernardo Botella
> Priority: Normal
> Attachments: ci_summary.html
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Right now, we have column_value_size_warn_threshold and
> column_value_size_fail_threshold guardrails, which are generic guardrails
> that are applied at write time to all columns with applicable datatypes.
> This Jira is about adding specific per type size guard rails to allow even
> further flexibility to specify those limits. Actual limit would be the
> smaller between the general column_value_size_*_threshold and the specific
> column_type_value_size_*_threshold.
> The list of guardrails to add is:
> * column_ascii_value_size_warn_threshold
> * column_ascii_value_size_fail_threshold
> * column_blob_value_size_warn_threshold
> * column_blob_value_size_fail_threshold
> * column_text_value_size_warn_threshold
> * column_text_value_size_fail_threshold
> * column_varchar_value_size_warn_threshold
> * column_varchar_value_size_fail_threshold
> For collections, we have a similar guardrail called
> collection_size_warn_threshold and collection_size_fail_threshold, with some
> differences on how it is applied (look at the cassandra.yaml
> [documentation|[https://github.com/apache/cassandra/blob/trunk/conf/cassandra.yaml#L2080]]).
> Similarly, we should add:
> * collection_map_size_warn_threshold
> * collection_map_size_fail_threshold
> * collection_set_size_warn_threshold
> * collection_set_size_fail_threshold
> * collection_list_size_warn_threshold
> * collection_list_size_fail_threshold
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
