[
https://issues.apache.org/jira/browse/CASSANDRA-19783?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17867104#comment-17867104
]
Stefan Miklosovic edited comment on CASSANDRA-19783 at 7/18/24 8:21 PM:
------------------------------------------------------------------------
+1 from me, I guess it would be nice to provide build results upon the actual
merge.
was (Author: smiklosovic):
+1 from me, I guess I would be nice to provide build results upon the actual
merge.
> In-jvm dtest to detect InstanceClassLoaderLeaks
> -----------------------------------------------
>
> Key: CASSANDRA-19783
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19783
> Project: Cassandra
> Issue Type: Improvement
> Components: Test/dtest/java
> Reporter: Doug Rohrer
> Assignee: Doug Rohrer
> Priority: Normal
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> It is currently very easy to add dependencies/code that cause in-jvm dtest
> {{InstanceClassLoader}} leaks, and hard to find them. These patches add a
> WeakHashSet that allows us to count the number of reachable
> InstanceClassLoaders in the in-jvm dtest API, so that we can use it in the
> ResourceLeakTest in the actual Cassandra branches in CI (it only takes 2
> iterations to find the leak recently introduced by the inclusion of the
> {{oshi.jna}} library, which was fixed in
> [https://github.com/apache/cassandra-in-jvm-dtest-api/pull/38])
> Notes:
> The trunk patch +requires+ the changes made in the in-jvm-dtest-api project
> in order to compile.
> Additionally, ResourceLeakTest#looperEverythingTest (the newly-enabled test)
> won't fail once we pick up the changes made to include `osha.jna` in the
> in-jvm-dtest-api project, so I added some "DO NOT COMMIT" code there to prove
> the test can in fact detect the leak.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
