[
https://issues.apache.org/jira/browse/CASSANDRA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17868395#comment-17868395
]
Stefan Miklosovic commented on CASSANDRA-18111:
-----------------------------------------------
[CASSANDRA-18111|https://github.com/instaclustr/cassandra/tree/CASSANDRA-18111]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 22s
✓ j17_cqlsh_dtests_py311 6m 59s
✓ j17_cqlsh_dtests_py311_vnode 8m 4s
✓ j17_cqlsh_dtests_py38 6m 48s
✓ j17_cqlsh_dtests_py38_vnode 7m 10s
✓ j17_cqlshlib_cython_tests 7m 54s
✓ j17_cqlshlib_tests 6m 29s
✓ j17_dtests 37m 50s
✓ j17_dtests_latest 36m 25s
✓ j17_dtests_vnode 36m 58s
✓ j17_utests_latest 14m 26s
✓ j17_utests_oa 14m 25s
✕ j17_jvm_dtests 24m 49s
org.apache.cassandra.fuzz.ring.ConsistentBootstrapTest
coordinatorIsBehindTest
✕ j17_jvm_dtests_latest_vnode 25m 19s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
✕ j17_unit_tests 13m 15s
org.apache.cassandra.tcm.DiscoverySimulationTest discoveryTest
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4531/workflows/10625d32-72dc-43c6-88b1-349f203bd38b]
> Centralize all snapshot operations to SnapshotManager and cache snapshots
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-18111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18111
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Paulo Motta
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> Everytime {{nodetool listsnapshots}} is called, all data directories are
> scanned to find snapshots, what is inefficient.
> For example, fetching the
> {{org.apache.cassandra.metrics:type=ColumnFamily,name=SnapshotsSize}} metric
> can take half a second (CASSANDRA-13338).
> This improvement will also allow snapshots to be efficiently queried via
> virtual tables (CASSANDRA-18102).
> In order to do this, we should:
> a) load all snapshots from disk during initialization
> b) keep a collection of snapshots on {{SnapshotManager}}
> c) update the snapshots collection anytime a new snapshot is taken or cleared
> d) detect when a snapshot is manually removed from disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
