[
https://issues.apache.org/jira/browse/CASSANDRA-19779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17869318#comment-17869318
]
Stefan Miklosovic edited comment on CASSANDRA-19779 at 7/29/24 10:48 AM:
-------------------------------------------------------------------------
[CASSANDRA-19779-5.0.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19779-5.0.0]
{noformat}
java17_pre-commit_tests
✓ j17_build 3m 35s
✓ j17_cqlsh_dtests_py311 6m 9s
✓ j17_cqlsh_dtests_py311_vnode 6m 20s
✓ j17_cqlsh_dtests_py38 6m 7s
✓ j17_cqlsh_dtests_py38_vnode 6m 17s
✓ j17_cqlshlib_cython_tests 7m 46s
✓ j17_cqlshlib_tests 6m 25s
✓ j17_dtests 33m 46s
✓ j17_dtests_latest 33m 15s
✓ j17_dtests_vnode 33m 5s
✓ j17_jvm_dtests 22m 54s
✓ j17_jvm_dtests_latest_vnode 14m 18s
✓ j17_unit_tests 14m 8s
✓ j17_unit_tests_repeat 2m 32s
✓ j17_utests_latest 14m 57s
✓ j17_utests_latest_repeat 2m 23s
✓ j17_utests_oa 15m 17s
✓ j17_utests_oa_repeat 2m 26s
java17_separate_tests
java11_pre-commit_tests
✓ j11_build 8m 4s
✓ j11_cqlsh_dtests_py311 8m 6s
✓ j11_cqlsh_dtests_py311_vnode 10m 49s
✓ j11_cqlsh_dtests_py38 8m 11s
✓ j11_cqlsh_dtests_py38_vnode 10m 42s
✓ j11_cqlshlib_cython_tests 11m 48s
✓ j11_cqlshlib_tests 11m 51s
✓ j11_dtests 38m 0s
✓ j11_dtests_latest 34m 42s
✓ j11_dtests_vnode 34m 32s
✓ j11_jvm_dtests 24m 7s
✓ j11_jvm_dtests_latest_vnode 17m 31s
✓ j11_simulator_dtests 6m 11s
✓ j11_unit_tests 16m 25s
✓ j11_unit_tests_repeat 6m 51s
✓ j11_utests_latest 18m 27s
✓ j11_utests_latest_repeat 6m 45s
✓ j11_utests_oa 17m 57s
✓ j11_utests_oa_repeat 6m 17s
✓ j11_utests_system_keyspace_directory 17m 28s
✓ j11_utests_system_keyspace_directory_repeat 6m 42s
✓ j17_cqlsh_dtests_py311 6m 4s
✓ j17_cqlsh_dtests_py311_vnode 6m 11s
✓ j17_cqlsh_dtests_py38 6m 13s
✓ j17_cqlsh_dtests_py38_vnode 6m 25s
✓ j17_cqlshlib_cython_tests 7m 51s
✓ j17_cqlshlib_tests 8m 29s
✓ j17_dtests 32m 37s
✓ j17_dtests_latest 32m 48s
✓ j17_dtests_vnode 33m 0s
✓ j17_jvm_dtests 23m 39s
✓ j17_jvm_dtests_latest_vnode 14m 8s
✓ j17_unit_tests 13m 43s
✓ j17_unit_tests_repeat 3m 0s
✓ j17_utests_latest 15m 43s
✓ j17_utests_latest_repeat 2m 20s
✓ j17_utests_oa 13m 47s
✓ j17_utests_oa_repeat 2m 47s
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4545/workflows/685986d2-baf0-4ab8-badb-91b12e4acd06]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4545/workflows/445a76b5-131d-49ba-bb03-7ce48f050256]
This is with a branch which gets rid of InMemory.
was (Author: smiklosovic):
[CASSANDRA-19779-5.0.0|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19779-5.0.0]
{noformat}
java17_pre-commit_tests
✓ j17_build 3m 35s
✓ j17_cqlsh_dtests_py311 6m 9s
✓ j17_cqlsh_dtests_py311_vnode 6m 20s
✓ j17_cqlsh_dtests_py38 6m 7s
✓ j17_cqlsh_dtests_py38_vnode 6m 17s
✓ j17_cqlshlib_cython_tests 7m 46s
✓ j17_cqlshlib_tests 6m 25s
✓ j17_dtests 33m 46s
✓ j17_dtests_latest 33m 15s
✓ j17_dtests_vnode 33m 5s
✓ j17_jvm_dtests 22m 54s
✓ j17_jvm_dtests_latest_vnode 14m 18s
✓ j17_unit_tests 14m 8s
✓ j17_unit_tests_repeat 2m 32s
✓ j17_utests_latest 14m 57s
✓ j17_utests_latest_repeat 2m 23s
✓ j17_utests_oa 15m 17s
✓ j17_utests_oa_repeat 2m 26s
java17_separate_tests
java11_pre-commit_tests
✓ j11_build 8m 4s
✓ j11_cqlsh_dtests_py311 8m 6s
✓ j11_cqlsh_dtests_py311_vnode 10m 49s
✓ j11_cqlsh_dtests_py38 8m 11s
✓ j11_cqlsh_dtests_py38_vnode 10m 42s
✓ j11_cqlshlib_cython_tests 11m 48s
✓ j11_cqlshlib_tests 11m 51s
✓ j11_dtests 38m 0s
✓ j11_dtests_latest 34m 42s
✓ j11_dtests_vnode 34m 32s
✓ j11_jvm_dtests 24m 7s
✓ j11_jvm_dtests_latest_vnode 17m 31s
✓ j11_simulator_dtests 6m 11s
✓ j11_unit_tests 16m 25s
✓ j11_unit_tests_repeat 6m 51s
✓ j11_utests_latest 18m 27s
✓ j11_utests_latest_repeat 6m 45s
✓ j11_utests_oa 17m 57s
✓ j11_utests_oa_repeat 6m 17s
✓ j11_utests_system_keyspace_directory 17m 28s
✓ j11_utests_system_keyspace_directory_repeat 6m 42s
✓ j17_cqlsh_dtests_py311 6m 4s
✓ j17_cqlsh_dtests_py311_vnode 6m 11s
✓ j17_cqlsh_dtests_py38 6m 13s
✓ j17_cqlsh_dtests_py38_vnode 6m 25s
✓ j17_cqlshlib_cython_tests 7m 51s
✓ j17_cqlshlib_tests 8m 29s
✓ j17_dtests 32m 37s
✓ j17_dtests_latest 32m 48s
✓ j17_dtests_vnode 33m 0s
✓ j17_jvm_dtests 23m 39s
✓ j17_jvm_dtests_latest_vnode 14m 8s
✓ j17_unit_tests 13m 43s
✓ j17_unit_tests_repeat 3m 0s
✓ j17_utests_latest 15m 43s
✓ j17_utests_latest_repeat 2m 20s
✓ j17_utests_oa 13m 47s
✓ j17_utests_oa_repeat 2m 47s
java11_separate_tests
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4545/workflows/685986d2-baf0-4ab8-badb-91b12e4acd06]
[java17_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4545/workflows/445a76b5-131d-49ba-bb03-7ce48f050256]
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4545/workflows/87401fae-5a0a-4c0f-bf91-959614eef8df]
[java11_separate_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4545/workflows/a6bc4e13-4c95-4261-abd7-7c2390d93cb7]
> direct IO support is always evaluated to false upon the very first start of a
> node
> ----------------------------------------------------------------------------------
>
> Key: CASSANDRA-19779
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19779
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Tools
> Reporter: Stefan Miklosovic
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.0-rc
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> When I extract the distribution tarball and I want to use tools in tools/bin,
> there is this warn log visible every time for tools when they are started
> (does not happen on "help" command, obviously)
> {code:java}
> WARN 14:25:11,835 Unable to determine block size for commit log directory:
> null {code}
> This is because we introduced this (1) in CASSANDRA-18464
> What that does is that it will go and try to create a temporary file in
> commit log directory to get "block size" for a "file store" that file is in.
> The problem with that is that when we just extract a tarball and run the
> tools - Cassandra was never started - then such commit log directory does not
> exist yet, so it tries to create a temporary file in a non-existing
> directory, which fails, hence the log message.
> The fix is to check if commitlog dir exists and return / skip the resolution
> of block size if it does not.
> Another approach might be to check if this is executed in the context of a
> tool and skip it from resolution altogether. The problem with this is that
> not all tools we have in bin/log call DatabaseDescriptor.
> toolInitialization() so we might combine these two.
> (1)
> [https://github.com/apache/cassandra/blob/cassandra-5.0/src/java/org/apache/cassandra/config/DatabaseDescriptor.java#L1455-L1462]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
