OleksiienkoMykyta commented on code in PR #1791:
URL:
https://github.com/apache/cassandra-gocql-driver/pull/1791#discussion_r1705000021
##########
cassandra_test.go:
##########
@@ -2278,12 +2283,17 @@ func TestMaterializedViewMetadata(t *testing.T) {
DefaultTimeToLive: 0,
Extensions: map[string]string{},
GcGraceSeconds: 864000,
- IncludeAllColumns: false, MaxIndexInterval: 2048,
MemtableFlushPeriodInMs: 0, MinIndexInterval: 128, ReadRepairChance: 0,
- SpeculativeRetry: expectedSpeculativeRetry,
+ IncludeAllColumns: false, MaxIndexInterval: 2048,
+ MemtableFlushPeriodInMs: 0,
+ MinIndexInterval: 128,
+ ReadRepair: expectedReadRepair,
+ ReadRepairChance: 0,
Review Comment:
Yes, but this test also runs for C* 3.0.0, so it covers data for all
versions. We can make separate tests for each version, but as mentioned in the
description for the current PR, the main aim is to implement a
backward-compatible metadata getter, and this test case helps to test one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
