[
https://issues.apache.org/jira/browse/CASSANDRA-19812?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874127#comment-17874127
]
Stefan Miklosovic commented on CASSANDRA-19812:
-----------------------------------------------
[CASSANDRA-19812-trunk|https://github.com/instaclustr/cassandra/tree/CASSANDRA-19812-trunk]
{noformat}
java11_pre-commit_tests
✓ j11_build 4m 0s
✓ j11_cqlsh_dtests_py311 10m 56s
✓ j11_cqlsh_dtests_py311_vnode 8m 14s
✓ j11_cqlsh_dtests_py38 10m 59s
✓ j11_cqlsh_dtests_py38_vnode 7m 34s
✓ j11_cqlshlib_cython_tests 8m 11s
✓ j11_cqlshlib_tests 8m 57s
✓ j11_dtests 37m 33s
✓ j11_simulator_dtests 6m 40s
✓ j11_unit_tests_repeat 6m 56s
✓ j11_utests_latest 15m 17s
✓ j11_utests_latest_repeat 7m 25s
✓ j11_utests_oa 15m 6s
✓ j11_utests_oa_repeat 7m 19s
✓ j11_utests_system_keyspace_directory 15m 56s
✓ j11_utests_system_keyspace_directory_repeat 7m 18s
✓ j17_cqlsh_dtests_py311 7m 13s
✓ j17_cqlsh_dtests_py311_vnode 7m 35s
✓ j17_cqlsh_dtests_py38 7m 23s
✓ j17_cqlsh_dtests_py38_vnode 7m 22s
✓ j17_cqlshlib_cython_tests 10m 33s
✓ j17_cqlshlib_tests 6m 58s
✓ j17_dtests 34m 16s
✓ j17_dtests_vnode 38m 52s
✓ j17_unit_tests 13m 43s
✓ j17_unit_tests_repeat 3m 54s
✓ j17_utests_latest 14m 23s
✓ j17_utests_latest_repeat 3m 47s
✓ j17_utests_oa 14m 0s
✓ j17_utests_oa_repeat 3m 47s
✕ j11_dtests_latest 37m 5s
configuration_test.TestConfiguration test_change_durable_writes
✕ j11_dtests_vnode 52m 24s
bootstrap_test.TestBootstrap test_killed_wiped_node_cannot_join
✕ j11_jvm_dtests 26m 9s
org.apache.cassandra.distributed.test.ReadSpeculationTest speculateTest
✕ j11_jvm_dtests_latest_vnode 29m 2s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
✕ j11_unit_tests 15m 49s
org.apache.cassandra.service.JoinTokenRingTest testIndexPreJoinInvocation
org.apache.cassandra.net.ProxyHandlerConnectionsTest testExpireSome
TIMEOUTED
✕ j17_dtests_latest 37m 38s
bootstrap_test.TestBootstrap
test_consistent_range_movement_false_with_replica_down_should_succeed
✕ j17_jvm_dtests 24m 46s
✕ j17_jvm_dtests_latest_vnode 25m 31s
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
{noformat}
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4615/workflows/866e1e20-ce22-4be6-b79c-f02cc7cff3c9]
> We should throw exception when commitlog 's DiskAccessMode is direct but
> direct io is not support
> -------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-19812
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19812
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Commit Log
> Reporter: Maxwell Guo
> Assignee: Maxwell Guo
> Priority: Normal
> Fix For: 5.0.x, 5.x
>
>
> Looking into the code below :
> {code:java}
> private static DiskAccessMode
> resolveCommitLogWriteDiskAccessMode(DiskAccessMode providedDiskAccessMode)
> {
> boolean compressOrEncrypt = getCommitLogCompression() != null ||
> (getEncryptionContext() != null && getEncryptionContext().isEnabled());
> boolean directIOSupported = false;
> try
> {
> directIOSupported = FileUtils.getBlockSize(new
> File(getCommitLogLocation())) > 0;
> }
> catch (RuntimeException e)
> {
> logger.warn("Unable to determine block size for commit log
> directory: {}", e.getMessage());
> }
> if (providedDiskAccessMode == DiskAccessMode.auto)
> {
> if (compressOrEncrypt)
> providedDiskAccessMode = DiskAccessMode.legacy;
> else
> {
> providedDiskAccessMode = directIOSupported &&
> conf.disk_optimization_strategy == Config.DiskOptimizationStrategy.ssd ?
> DiskAccessMode.direct
>
> :
> DiskAccessMode.legacy;
> }
> }
> if (providedDiskAccessMode == DiskAccessMode.legacy)
> {
> providedDiskAccessMode = compressOrEncrypt ?
> DiskAccessMode.standard : DiskAccessMode.mmap;
> }
> return providedDiskAccessMode;
> }
> {code}
> We should throw exception when user set the DiskAccessMode to direct for
> commitlog but the directIOSupported return false after the judgement of
> "FileUtils.getBlockSize(new File(getCommitLogLocation())) > 0;" instead of
> waiting for the system to start and accepting reads and writes.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
