[
https://issues.apache.org/jira/browse/CASSANDRA-19651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17874527#comment-17874527
]
Dmitry Konstantinov edited comment on CASSANDRA-19651 at 8/17/24 3:53 PM:
--------------------------------------------------------------------------
4.0 - 3 test failures, all of the looks like not related to the current changes
* cql3.MemtableSizeTest#testTruncationReleasesLogSpace - known broken:
CASSANDRA-17298, fail locally with and without changes
I have some ideas how to make it better and plan to provide an update in
CASSANDRA-17298
* cqlsh_tests.test_cqlsh_copy.TestCqlshCopy#test_bulk_round_trip_with_timeouts
- known flaky: CASSANDRA-18189, passed locally
* distributed.upgrade.DropCompactStorageTest#testDropCompactStorage - known
flaky: CASSANDRA-17674, passed locally
{code:java}
% pytest --cassandra-dir=/Users/dmitry/IdeaProjects/cassandra-4.0
cqlsh_tests/test_cqlsh_copy.py::TestCqlshCopy::test_bulk_round_trip_with_timeouts
/
...
test_bulk_round_trip_with_timeouts passed 1 out of the required 1 times.
Success!
===End Flaky Test Report===
=================================================================== 1 passed,
67 warnings in 37.67s
===================================================================
{code}
!image-2024-08-17-16-52-58-856.png|thumbnail!
was (Author: dnk):
4.0 - 3 test failures, all of the looks like not related to the current changes
* cql3.MemtableSizeTest#testTruncationReleasesLogSpace - known broken:
CASSANDRA-17298, fail locally with and without changes
I have some ideas how to make it better and plan to provide an update in
CASSANDRA-17298
* cqlsh_tests.test_cqlsh_copy.TestCqlshCopy#test_bulk_round_trip_with_timeouts
- known flaky: CASSANDRA-18189, passed locally
* distributed.upgrade.DropCompactStorageTest#testDropCompactStorage - known
flaky: CASSANDRA-17674, passed locally
{code:java}
% pytest --cassandra-dir=/Users/dmitry/IdeaProjects/cassandra-4.0
cqlsh_tests/test_cqlsh_copy.py::TestCqlshCopy::test_bulk_round_trip_with_timeouts
/
...
test_bulk_round_trip_with_timeouts passed 1 out of the required 1 times.
Success!
===End Flaky Test Report===
=================================================================== 1 passed,
67 warnings in 37.67s
===================================================================
{code}
!image-2024-08-17-16-52-15-995.png|thumbnail!
> idealCLWriteLatency metric reports the worst response time instead of the
> time when ideal CL is satisfied
> ---------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-19651
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19651
> Project: Cassandra
> Issue Type: Bug
> Components: Legacy/Observability
> Reporter: Dmitry Konstantinov
> Assignee: Dmitry Konstantinov
> Priority: Normal
> Fix For: 4.1.x, 5.0.x, 5.x
>
> Attachments:
> ci_summary-cassandra-4.0-a75f6c3e81f677e50c0a0d467dd5dad672f923e3.html,
> ci_summary-cassandra-4.1-1ed312f881c0c170c8833ff9fbf397ab8fc625cc.html,
> ci_summary-cassandra-5.0-009f2982ac88d9c9bc0a7a7d29220f055aa7f11e.html,
> ci_summary-trunk-da68729322515b4a7a698b73a0154ecdeb3abf39.html,
> image-2024-08-17-16-52-58-856.png,
> result_details-cassandra-4.0-a75f6c3e81f677e50c0a0d467dd5dad672f923e3.tar.gz,
> result_details-cassandra-5.0-009f2982ac88d9c9bc0a7a7d29220f055aa7f11e.tar.gz,
> result_details-trunk-da68729322515b4a7a698b73a0154ecdeb3abf39.tar.gz
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> org.apache.cassandra.service.AbstractWriteResponseHandler:
> {code:java}
> private final void decrementResponseOrExpired()
> {
> int decrementedValue = responsesAndExpirations.decrementAndGet();
> if (decrementedValue == 0)
> {
> // The condition being signaled is a valid proxy for the CL being
> achieved
> // Only mark it as failed if the requested CL was achieved.
> if (!condition.isSignalled() && requestedCLAchieved)
> {
> replicaPlan.keyspace().metric.writeFailedIdealCL.inc();
> }
> else
> {
>
> replicaPlan.keyspace().metric.idealCLWriteLatency.addNano(nanoTime() -
> queryStartNanoTime);
> }
> }
> } {code}
> Actual result: responsesAndExpirations is a total number of replicas across
> all DCs which does not depend on the ideal CL, so the metric value for
> replicaPlan.keyspace().metric.idealCLWriteLatency is updated when we get the
> latest response/timeout for all replicas.
> Expected result: replicaPlan.keyspace().metric.idealCLWriteLatency is updated
> when we get enough responses from replicas according to the ideal CL.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
