jberragan commented on code in PR #71:
URL:
https://github.com/apache/cassandra-analytics/pull/71#discussion_r1721425892
##########
cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/CqlField.java:
##########
@@ -330,14 +329,39 @@ public CqlType type()
return type;
}
- public Object deserialize(ByteBuffer buffer)
+ public Object deserializeToType(TypeConverter converter, ByteBuffer buffer)
+ {
+ return deserializeToType(converter, buffer, false);
+ }
+
+ /**
+ * Deserialize raw ByteBuffer from Cassandra type and convert to a new
type using the TypeConverter.
+ *
+ * @param converter custom TypeConverter that maps Cassandra type to some
other type.
+ * @param buffer raw ByteBuffer
+ * @param isFrozen true if the Cassandra type is frozen
+ * @return deserialized object converted to custom type.
+ */
+ public Object deserializeToType(TypeConverter converter, ByteBuffer
buffer, boolean isFrozen)
Review Comment:
`TypeConverter` is designed to be generic and not tied to Spark, so it could
be some other type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
