[ 
https://issues.apache.org/jira/browse/CASSANDRA-3297?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121135#comment-13121135
 ] 

Sylvain Lebresne commented on CASSANDRA-3297:
---------------------------------------------

nitpick: the assert that segments is not empty in CL.createNewSegment() could 
be moved one line up since sync() already assume this.

But otherwise, patch lgtm. +1.
                
> truncate can still result in data being replayed after a restart
> ----------------------------------------------------------------
>
>                 Key: CASSANDRA-3297
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-3297
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 0.8.0
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>              Labels: commitlog
>             Fix For: 0.8.8
>
>         Attachments: 3297.txt
>
>
> Our first stab at fixing this was CASSANDRA-2950.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to