lukasz-antoniak commented on issue #1803: URL: https://github.com/apache/cassandra-gocql-driver/issues/1803#issuecomment-2315210740
Do you expect the retry of non-idempotent queries or not? I could not clearly understand expected behaviour. The ticket you mentioned was implementing _speculative_ retry policy, which is something different. Retry policy in Java driver is: 1. Used for Query statements, because those are implicitly idempotent. 2. For write operations it depends on idempotency flag set [CqlRequestHandler.java#L775](https://github.com/apache/cassandra-java-driver/blob/4.x/core/src/main/java/com/datastax/oss/driver/internal/core/cql/CqlRequestHandler.java#L775). Retry policy implementations do not need to check idempotency flag. IMHO same logic shall apply in GoCQL. Retry policy shall not be even invoked for non0idempotent write operations. Do I understand the issue correctly? If so, I will submit a fix for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
