[
https://issues.apache.org/jira/browse/CASSANDRA-19796?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17879165#comment-17879165
]
Stefan Miklosovic edited comment on CASSANDRA-19796 at 9/4/24 10:07 AM:
------------------------------------------------------------------------
Thank you for your investigation, [~taaraora]!
I like (1) which abandons ccm in favor of testcontainers a lot. I think that
this should be done, we at least drop ccm dependency from the test process as
well as it will simplify .github/workflows/main.yml as such, moving all the
configuration details in a separate file testcontainers execute. This would
also simplify developer's setup as all which is needed to test it locally is
just Go.
I see that the testing matrix is executing tests only against 4.0.8 and the PR
(1) changes this to cassandra_version: [ '4.0.8', '4.1.1' ] which is also good
work, I would include 5.0.0 into that as well as soon as we release it. Would
you mind to update the PR or contact the author of that PR to work on that?
I agree that we should bump the versions of Go to what you mentioned.
AFAIK The documentation lacks any explanation how to run the tests locally. Do
you think this is something which could be improved in the PR as well so people
know how to test this locally? There should be a way how people can run the
"pipeline" locally for their evaluation before they submit the PR. We have
scripts for this in Cassandra (to execute some tests in a container at least as
runtime of CI for Cassandra is way beyond what can 1 machine handle). So, we
should address local execution of all tests with defined Cassandra version and
let a developer execute that locally as well.
I am not completely sure how that would look like but, ideally, it would be
just a script a user can execute locally and this very same script would be
just called from .github/workflows/main.yml as workflow is triggered. If local
test execution is also possible, then non-maintainers do not need to wait for
maintainers to trigger it. We can also mention in PR message template that
people are welcome to test this locally before submitting a PR.
In general, we should figure this all out and stabilise the CI (fix flaky tests
etc) before the very first official release under Apache. That deserves its own
discussion but I think it is prerequisite for that to happen.
(1) https://github.com/apache/cassandra-gocql-driver/pull/1780/
was (Author: smiklosovic):
Thank you for your investigation, [~taaraora]!
I like (1) which abandons ccm in favor of testcontainers a lot. I think that
this should be done, we at least drop ccm dependency from the test process as
well as it will simplify .github/workflows/main.yml as such, moving all the
configuration details in a separate file testcontainers execute. This would
also simplify developer's setup as all which is needed to test it locally is
just Go.
I see that the testing matrix is executing tests only against 4.0.8 and the PR
(1) changes this to cassandra_version: [ '4.0.8', '4.1.1' ] which is also good
work, I would include 5.0.0 into that as well as soon as we release it. Would
you mind to update the PR or contact the author of that PR to work on that?
I agree that we should bump the versions of Go to what you mentioned.
AFAIK The documentation lacks any explanation how to run the tests locally. Do
you think this is something which could be improved in the PR as well so people
know how to test this locally? There should be a way how people can run the
"pipeline" locally for their evaluation before they submit the PR. We have
scripts for this in Cassandra (to execute some tests in a container at least as
runtime of CI for Cassandra is way beyond what can 1 machine handle). So, we
should address local execution of all tests with defined Cassandra version and
let a developer execute that locally as well.
I am not completely sure how that would look like but, ideally, it would be
just a script a user can execute locally and this very same script would be
just called from .github/workflows/main.yml as workflow is triggered.
In general, we should figure this all out and stabilise the CI (fix flaky tests
etc) before the very first official release under Apache. That deserves its own
discussion but I think it is prerequisite for that to happen.
(1) https://github.com/apache/cassandra-gocql-driver/pull/1780/
> Setup cassandra-gocql-driver CI
> -------------------------------
>
> Key: CASSANDRA-19796
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19796
> Project: Cassandra
> Issue Type: Sub-task
> Components: CI, Client/gocql-driver
> Reporter: Michael Semb Wever
> Assignee: Dmytro Tsapko
> Priority: Normal
>
> This may be just confirming GHA still works.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
