jberragan commented on code in PR #71:
URL:
https://github.com/apache/cassandra-analytics/pull/71#discussion_r1752638296
##########
cassandra-four-zero-bridge/src/main/java/org/apache/cassandra/bridge/CassandraBridgeImplementation.java:
##########
@@ -176,16 +176,18 @@ public CassandraBridgeImplementation()
kryoSerializers.put(CqlField.class, new
CqlField.Serializer(cassandraTypes()));
kryoSerializers.put(CqlTable.class, new
CqlTable.Serializer(cassandraTypes()));
kryoSerializers.put(CqlUdt.class, new
CqlUdt.Serializer(cassandraTypes()));
-
- nativeTypes =
allTypes().stream().collect(Collectors.toMap(CqlField.CqlType::name,
Function.identity()));
}
- @Override
public CassandraTypes cassandraTypes()
{
return CassandraTypesImplementation.INSTANCE;
}
+ public SparkSqlTypeConverter typeConverter()
+ {
+ return SparkSqlTypeConverterImplementation.INSTANCE;
Review Comment:
We could remove the Spark dependency from `cassandra-bridge` but it would be
a lot more work and probably better to do outside this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
