[ 
https://issues.apache.org/jira/browse/CASSANDRA-17298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17881061#comment-17881061
 ] 

Dmitry Konstantinov commented on CASSANDRA-17298:
-------------------------------------------------

[~smiklosovic]

It looks like during a merge the old test was not removed (was re-added back) 
in 4.1: 
[https://github.com/apache/cassandra/blob/cassandra-4.1/test/unit/org/apache/cassandra/cql3/MemtableSizeTest.java]
  (the commit has the removal - 
[https://github.com/apache/cassandra/commit/c56ba3b317e67f4530db1737169f5558969bd531#diff-e7b2385cd817d698d35bdeffea2d4cb765653e2e3eb13fa22abfb070fed05a8f]
 )

> Improve accuracy of memtable heap usage tracking
> ------------------------------------------------
>
>                 Key: CASSANDRA-17298
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17298
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Test/unit
>            Reporter: Josh McKenzie
>            Assignee: Dmitry Konstantinov
>            Priority: Normal
>             Fix For: 4.0.14, 4.1.7, 5.0.1, 5.1
>
>         Attachments: analyzed_objects.svg, structure_example.svg
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> [https://ci-cassandra.apache.org/job/Cassandra-4.0/313/testReport/org.apache.cassandra.cql3/MemtableSizeTest/testTruncationReleasesLogSpace_2/]
>  Failed 4 times in the last 30 runs. Flakiness: 27%, Stability: 86%
> Error Message
> Expected heap usage close to 49.930MiB, got 41.542MiB.
> {code}
> Stacktrace
> junit.framework.AssertionFailedError: Expected heap usage close to 49.930MiB, 
> got 41.542MiB.
>       at 
> org.apache.cassandra.cql3.MemtableSizeTest.testSize(MemtableSizeTest.java:130)
>       at org.apache.cassandra.Util.runCatchingAssertionError(Util.java:644)
>       at org.apache.cassandra.Util.flakyTest(Util.java:669)
>       at 
> org.apache.cassandra.cql3.MemtableSizeTest.testTruncationReleasesLogSpace(MemtableSizeTest.java:61)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>       at 
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>       at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>  {code}
> *UPDATE:* It was discovered that unit tests were running with 
> memtable_allocation_type: offheap_objects when we ship C* with heap_buffers.
> So we changed that in CASSANDRA-19326, now we test with 
> memtable_allocation_type: heap_buffers. As a result, this test now fails all 
> the time on 4.0 and 4.1. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to