[
https://issues.apache.org/jira/browse/CASSANDRA-19863?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17887575#comment-17887575
]
Michael Semb Wever edited comment on CASSANDRA-19863 at 10/8/24 7:39 PM:
-------------------------------------------------------------------------
CompactionStrategyManagerPendingRepairTest.testFinalizedAndCompactionRace is
consistently failing, on both jdk11 and 17, on unit-latest tests.
-
https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-5.0/failure/org.apache.cassandra.db.compaction/CompactionStrategyManagerPendingRepairTest/testFinalizedAndCompactionRace
-
https://ci-cassandra.apache.org/job/Cassandra-5.0/316/testReport/junit/org.apache.cassandra.db.compaction/CompactionStrategyManagerPendingRepairTest/Tests___test_latest_jdk11_4_8___testFinalizedAndCompactionRace_latest_jdk11_x86_64/
Easy to reproduce
{code}
# fails (and slow first time to download docker image)
.build/docker/run-tests.sh test-latest
CompactionStrategyManagerPendingRepairTest 11
# works
.build/docker/run-tests.sh test CompactionStrategyManagerPendingRepairTest 11
{code}
Or, if we takes the changes from CASSANDRA-18942
(i.e. with {{git cherry-pick -n cassandra-5.0..thelastpickle/mck/18942/5.0}}
{code}
# fails (and slow first time to download docker image)
.build/docker/run-tests.sh -a test-latest -t
CompactionStrategyManagerPendingRepairTest
# works
.build/docker/run-tests.sh -a test -t CompactionStrategyManagerPendingRepairTest
{code}
was (Author: michaelsembwever):
CompactionStrategyManagerPendingRepairTest.testFinalizedAndCompactionRace is
consistently failing, on both jdk11 and 17, on unit-latest tests.
-
https://butler.cassandra.apache.org/#/ci/upstream/workflow/Cassandra-5.0/failure/org.apache.cassandra.db.compaction/CompactionStrategyManagerPendingRepairTest/testFinalizedAndCompactionRace
-
https://ci-cassandra.apache.org/job/Cassandra-5.0/316/testReport/junit/org.apache.cassandra.db.compaction/CompactionStrategyManagerPendingRepairTest/Tests___test_latest_jdk11_4_8___testFinalizedAndCompactionRace_latest_jdk11_x86_64/
> Add extra compaction junit
> --------------------------
>
> Key: CASSANDRA-19863
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19863
> Project: Cassandra
> Issue Type: Improvement
> Components: Local/Compaction
> Reporter: Berenguer Blasi
> Assignee: Berenguer Blasi
> Priority: Normal
> Fix For: 4.0.14, 4.1.7, 5.0.1, 5.1
>
>
> Working on a custom compaction strategy we have found there is no junit
> making sure compactions strategies account for this specific scenario:
> A- IR sessions starts on N sstables
> B- Just before the IR session completes and the N sstables get moved out of
> pending repair a compaction kicks in
> C- As the IR session is finalizing the compaction task removes the N sstables
> and creates a new one that will obviously be pending repair.
> D- The IR session finalizes, the original N sstables are gone, the compaction
> finishes and a new sstable pending repair is created
> E- That new sstable is orphaned as A. No active IR session knows about it B.
> No compaction is going to ever touch it as long as it is pending repair. So
> it it’s just left behind forever.
> This ticket will add such junit.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
