[
https://issues.apache.org/jira/browse/CASSANDRA-19991?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17888080#comment-17888080
]
Stefan Miklosovic edited comment on CASSANDRA-19991 at 10/10/24 12:57 AM:
--------------------------------------------------------------------------
[4.0 multiplex
j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4854/workflows/83a3f5f8-f2a8-4d02-bf8d-3667c42fb08f/jobs/286437]
[4.0 multiplex
j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4854/workflows/cd8647e6-8f35-4a39-9a28-17fd947d8d1a/jobs/286436]
[4.1 multiplex
j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4855/workflows/56773678-d64f-445a-89ae-e2735389a48c/jobs/286537]
[4.1 multiples
j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4855/workflows/13e271f3-7086-4192-8289-6cad5bc00b52/jobs/286538]
[5.0 multiplex
j17|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4860/workflows/352bbc8b-6b15-4b6f-8cd2-0c70e1844ea2/jobs/287091]
[5.0 multiplex
j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4860/workflows/c25bcff8-6ad4-4466-89eb-f7664cddaf50/jobs/287092]
[trunk
j17|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4861/workflows/cdaf46dd-d6c0-4e91-91a4-b61748eaebc0/jobs/287089]
[trunk
j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4861/workflows/da446d18-682a-482b-a6ee-38e782270f7e/jobs/287090]
one small nit in PR for 4.0 (probably too in 4.1) otherwise looks good.
[~dnk] how does this behave in 5.0+ ? I see the test is the same there. I dont
have any reason to believe that this is not flaky in 5.0+. Would you mind to
prepare the patches for that too?
EDIT: I have added all builds for 5.0 and trunk with respective branches.
was (Author: smiklosovic):
[4.0 multiplex
j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4854/workflows/83a3f5f8-f2a8-4d02-bf8d-3667c42fb08f/jobs/286437]
[4.0 multiplex
j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4854/workflows/cd8647e6-8f35-4a39-9a28-17fd947d8d1a/jobs/286436]
[4.1 multiplex
j11|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4855/workflows/56773678-d64f-445a-89ae-e2735389a48c/jobs/286537]
[4.1 multiples
j8|https://app.circleci.com/pipelines/github/instaclustr/cassandra/4855/workflows/13e271f3-7086-4192-8289-6cad5bc00b52/jobs/286538]
one small nit in PR for 4.0 (probably too in 4.1) otherwise looks good.
[~dnk] how does this behave in 5.0+ ? I see the test is the same there. I dont
have any reason to believe that this is not flaky in 5.0+. Would you mind to
prepare the patches for that too?
> Unit test
> org.apache.cassandra.tools.TopPartitionsTest#testServiceTopPartitionsSingleTable
> is still flaky
> ---------------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-19991
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19991
> Project: Cassandra
> Issue Type: Bug
> Components: Test/unit
> Reporter: Dmitry Konstantinov
> Assignee: Dmitry Konstantinov
> Priority: Normal
> Fix For: 4.0.x, 4.1.x, 5.0.x, 5.x
>
> Attachments: image-2024-10-09-22-28-39-629.png,
> image-2024-10-09-22-29-03-576.png
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> org.apache.cassandra.tools.TopPartitionsTest#testServiceTopPartitionsSingleTable
> fails randomly and quite frequently on CI:
> [https://ci-cassandra.apache.org/view/Cassandra%204.1/job/Cassandra-4.1/521/testReport/org.apache.cassandra.tools/TopPartitionsTest/]
> [https://ci-cassandra.apache.org/job/Cassandra-4.0/726/testReport/junit/org.apache.cassandra.tools/TopPartitionsTest/]
> Based on the source code - the most probably cause of this flakiness is async
> logic when we submit a sample here:
> org.apache.cassandra.metrics.Sampler#addSample - the submitted task can
> executed after we invoke finishLocalSampling(..) within the test.
> The failure can be emulated by adding a synthetic delay to this logic like
> this:
> {code:java}
> public void addSample(final T item, final int value)
> {
> if (isEnabled())
> samplerExecutor.submit(() -> {
> // ------ synthetic delay -----
> try
> {
> Thread.sleep(10000);
> } catch (Exception e) {};
> // ----------------------- -----
> insert(item, value);
> });
> }{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
