[ 
https://issues.apache.org/jira/browse/CASSANDRA-20015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17892623#comment-17892623
 ] 

Jordan West commented on CASSANDRA-20015:
-----------------------------------------

Generally agree with feedback from [~smiklosovic] with one note regarding that 
{{format}} function. Otherwise LGTM. Like Stefan said, we can kick off a build 
after the review comments are addressed. 

> nt compactionhistory should have a -H option
> --------------------------------------------
>
>                 Key: CASSANDRA-20015
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20015
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Local/Compaction
>            Reporter: Jordan West
>            Assignee: Cheng Wang
>            Priority: Normal
>
> {code:java}
> cassandra/cassandra-trunk | trunk $ bin/nodetool compactionhistory
> Compaction History:
> id                                   keyspace_name columnfamily_name   
> compacted_at            bytes_in bytes_out rows_merged compaction_properties
> 0a6c65c0-900f-11ef-9b27-69cda6595f36 system_schema functions           
> 2024-10-21T17:46:14.576 0        0         {}          
> {compaction_type:Compaction}
> 0a6c3eb0-900f-11ef-9b27-69cda6595f36 system_schema views               
> 2024-10-21T17:46:14.570 0        0         {}          
> {compaction_type:Compaction}
> 0a697f9a-900f-11ef-9b27-69cda6595f36 system_schema triggers            
> 2024-10-21T17:46:14.555 0        0         {}          
> {compaction_type:Compaction}
> 0a697f90-900f-11ef-9b27-69cda6595f36 system_schema aggregates          
> 2024-10-21T17:46:14.550 0        0         {}          
> {compaction_type:Compaction}
> 0a66996a-900f-11ef-9b27-69cda6595f36 system_schema types               
> 2024-10-21T17:46:14.537 0        0         {}          
> {compaction_type:Compaction}
> 0a669960-900f-11ef-9b27-69cda6595f36 system_schema column_masks        
> 2024-10-21T17:46:14.533 0        0         {}          
> {compaction_type:Compaction}
> 0a6316f0-900f-11ef-9b27-69cda6595f36 system_schema functions           
> 2024-10-21T17:46:14.514 0        0         {}          
> {compaction_type:Compaction}
> 0a61694a-900f-11ef-9b27-69cda6595f36 system_schema views               
> 2024-10-21T17:46:14.499 0        0         {}          
> {compaction_type:Compaction}
> 0a616940-900f-11ef-9b27-69cda6595f36 system_schema triggers            
> 2024-10-21T17:46:14.494 0        0         {}          
> {compaction_type:Compaction}
> 0a5eaa20-900f-11ef-9b27-69cda6595f36 system_schema aggregates          
> 2024-10-21T17:46:14.484 0        0         {}          
> {compaction_type:Compaction}
> 0a5dbfc0-900f-11ef-9b27-69cda6595f36 system_schema types               
> 2024-10-21T17:46:14.479 0        0         {}          
> {compaction_type:Compaction}
> 0a5bc3f0-900f-11ef-9b27-69cda6595f36 system_schema column_masks        
> 2024-10-21T17:46:14.465 0        0         {}          
> {compaction_type:Compaction}
> 0a597a00-900f-11ef-9b27-69cda6595f36 system_schema functions           
> 2024-10-21T17:46:14.447 0        0         {}          
> {compaction_type:Compaction}
> 0a46dc60-900f-11ef-9b27-69cda6595f36 system        local               
> 2024-10-21T17:46:14.437 1088     714       {6:1}       
> {compaction_type:Compaction}
> 0a5693d0-900f-11ef-9b27-69cda6595f36 system_schema views               
> 2024-10-21T17:46:14.428 0        0         {}          
> {compaction_type:Compaction}
> 0a522700-900f-11ef-9b27-69cda6595f36 system_schema triggers            
> 2024-10-21T17:46:14.409 0        0         {}          
> {compaction_type:Compaction}
> 0a4f19c0-900f-11ef-9b27-69cda6595f36 system_schema aggregates          
> 2024-10-21T17:46:14.383 0        0         {}          
> {compaction_type:Compaction}
> 0a4c0c80-900f-11ef-9b27-69cda6595f36 system_schema types               
> 2024-10-21T17:46:14.359 0        0         {}          
> {compaction_type:Compaction}
> 0a48d830-900f-11ef-9b27-69cda6595f36 system_schema column_masks        
> 2024-10-21T17:46:14.340 0        0         {}          
> {compaction_type:Compaction}
> 0a46b550-900f-11ef-9b27-69cda6595f36 system        sstable_activity    
> 2024-10-21T17:46:14.319 0        0         {}          
> {compaction_type:Compaction}
> 0a438100-900f-11ef-9b27-69cda6595f36 system        sstable_activity_v2 
> 2024-10-21T17:46:14.308 0        0         {}          
> {compaction_type:Compaction}
> cassandra/cassandra-trunk | trunk $ bin/nodetool compactionhistory  -H
> nodetool: Found unexpected parameters: [-H]
> See 'nodetool help' or 'nodetool help <command>'.
> cassandra/cassandra-trunk | trunk $ bin/cqlsh
> Connected to Test Cluster at 127.0.0.1:9042
> [cqlsh 6.3.0 | Cassandra 5.1-SNAPSHOT | CQL spec 3.4.8 | Native protocol v5]
> Use HELP for help.
> cqlsh> {code}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to