[
https://issues.apache.org/jira/browse/CASSANDRA-3188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13125914#comment-13125914
]
paul cannon commented on CASSANDRA-3188:
----------------------------------------
bq. Does it make sense to try to recover from thrift not being installed? I
think I'd rather raise a fatal error explaining the problem and how to fix it.
Or just leave it as a bare import and assume that if you're not installing from
a package you can deal with it. (pypi does allow specifiying dependencies
right?)
It doesn't help anything right now to try and recover- it's just a bit of
future-proofing for when we no longer need Thrift. I just tried to make the
Thrift parts easy to identify and excise when appropriate.
bq. I'm not a fan of adding another layer of default options besides the ones
in the server and in the Thrift CfDef. I also think the use case here is
misguided. (It's used to provide a "minimal" schema dump, skipping options that
are unchanged from the default.) If we change the defaults next release, we
want schemas being imported there to preserve their existing settings. So I
think verbosity is a good thing in this case.
Fair enough- I've found that a bunch of defaults are different between existing
c* versions already. It does bother me, though, that you get a big wall of text
from the DESCRIBE commands, even when you only want to see the meatiest parts.
Maybe that can be eased with some coloring, or maybe a different version of
DESCRIBE- something like {{DESCRIBE whatever SHORT}} to leave off display of
the options which are generally less interesting for everyday use?
bq. cql_type_to_apache_class feels like it might belong in the driver's
cql.marshal. (Shame on you Python stdlib for still not including a BiMap.
BiDict?)
I agree. I tried to keep driver changes to a minimum so I wouldn't have to
depend on the very-newest cassandra-dbapi2 release, but perhaps that's not very
useful.
I have a new version with some fixes, additions, and lots of nice help to
upload later today.
> cqlsh 2.0
> ---------
>
> Key: CASSANDRA-3188
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3188
> Project: Cassandra
> Issue Type: Improvement
> Reporter: Jonathan Ellis
> Assignee: paul cannon
> Fix For: 1.0.1
>
> Attachments: 3188.patch1.txt
>
>
> I'd like to see some improvements to cqlsh to bring it to feature parity w/
> the old cli:
> - describe [<KS> | <CF> | cluster | schema]
> - assume
> - connect / don't crap out w/ stacktrace if C* isn't currently running on
> localhost
> - help
> It may be easier to do this by forking the cli and replacing its one-off api
> with CQL, or it may be easier to add these features to cqlsh.
> Either is fine, but if it's a close call my inclination would be to build it
> in Java for the reasoning over on CASSANDRA-3010.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
