[ 
https://issues.apache.org/jira/browse/CASSANDRA-19105?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17899645#comment-17899645
 ] 

Brad Schoening edited comment on CASSANDRA-19105 at 11/20/24 4:55 AM:
----------------------------------------------------------------------

I agree the current code works nicely to fix the bug, but generally, committers 
want to see clean code.  

Sometimes, when you fix one bug, you uncover another issue, and that's what I 
see with the BNF for CAPTURE.


was (Author: bschoeni):
I agree the current code works to fix the bug, but generally, committers want 
to see clean code.  

Sometimes, when you fix one bug, you uncover another issue, and that's what I 
see with the BNF for CAPTURE.

> Fix CQLSH Capture to save query results only and not trace details when 
> Tracing is on
> -------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-19105
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19105
>             Project: Cassandra
>          Issue Type: Bug
>          Components: CQL/Interpreter
>            Reporter: Brad Schoening
>            Assignee: Gautam G
>            Priority: Normal
>         Attachments: test_results.txt, trunk_test_results.txt
>
>
> When using *Tracing* in CQLSH, it's sometimes helpful to use *Capture* to 
> avoid paging through output when you want to see the trace results.  However, 
> the trace results are also incorrectly captured to the output file.
> According to *Help Capture* (below), only the query result should be saved. 
> The correct behavior should display the trace results and only capture the 
> query results.
>         {_}Help capture message{_}:  Only query result output is captured. 
> Errors and output from cqlsh-only commands will still be shown in the cqlsh 
> session.
> Example:
> {quote}> TRACING ON;
> > select * from system_schema.columns LIMIT 1;
> > CAPTURE 'foo'
> {quote}
> this should display only the tracing information
> {quote}> CAPTURE OFF
> {quote}
> displays results and then the tracing
> {quote}> TRACING OFF
> {quote}
> displays only the results



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to