[ 
https://issues.apache.org/jira/browse/CASSANDRA-19964?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17902810#comment-17902810
 ] 

Maxwell Guo edited comment on CASSANDRA-19964 at 12/4/24 11:57 AM:
-------------------------------------------------------------------

Thanks [~smiklosovic] for you   review, yes , you are right , I didn't do the 
cloning thoroughly.I overlooked this point. It is indeed necessary to do a 
thorough isolation.

I will make an update later as you mentioned.

UPDATE:
When I was making changes based on your suggestions, I found that it is a great 
suggestion for copying tables if I parse the CQL statement based on the old 
table and replace it with the new table keyspace and new table name.

But there are some small points that need to be discussed to make it clear 
whether this path is really chosen in the end.
1、For indexes and triggers, as well as other feature that may be supported 
later, we are all going to using their CQL parsing and using new element to 
replace the old after parsing, right?
2、I am not clear with this :
{quote}but to do it in such a way that we will have a separate statement class 
as you did in your first PR.{quote}
you are ok on my first PR with CopyTableStatement ?


was (Author: maxwellguo):
Thanks [~smiklosovic] for you   review, yes , you are right , I didn't do the 
cloning thoroughly.I overlooked this point. It is indeed necessary to do a 
thorough isolation.

I will make an update later as you mentioned.

> CREATE TABLE LIKE for copying  Basic Table definition
> -----------------------------------------------------
>
>                 Key: CASSANDRA-19964
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-19964
>             Project: Apache Cassandra
>          Issue Type: New Feature
>          Components: Cluster/Schema, CQL/Syntax
>            Reporter: Maxwell Guo
>            Assignee: Maxwell Guo
>            Priority: Normal
>             Fix For: 5.x
>
>          Time Spent: 1h 20m
>  Remaining Estimate: 0h
>
> Introduce CREATE TABLE LIKE grammar that only COPY table's basic information: 
>  primary key , clustering key, regular column , and their data 
> types(including udt), data masking and table params , under the same keyspace 
> or different keyspace.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to