[
https://issues.apache.org/jira/browse/CASSSIDECAR-122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17903011#comment-17903011
]
Francisco Guerrero commented on CASSSIDECAR-122:
------------------------------------------------
Just addressing this comment here:
> I think simply renaming the config file would have worked fine to fix this
> issue. I'm not sure why we have the other stuff here.
There are two paths for using a configuration. 1) You can specify a URI in
{{sidecar.config}}, or 2) we lookup in the default path {{conf/sidecar.yaml}}.
For 2) we were doing a relative path URI. However, it is not possible to have a
relative path URI. So that's why we have to change the logic here. For 1, we
keep the existing behavior of looking up a URI. For the second case, we don't
use a URI for the path lookup and instead do a relative path search.
After removing the logic to fallback to reading the config yaml from resources,
the logic is pretty much the same except the handling for the second case.
I've also added test coverage that was missing for this code path.
> yaml configuration defaults to a file that doesn't exist
> --------------------------------------------------------
>
> Key: CASSSIDECAR-122
> URL: https://issues.apache.org/jira/browse/CASSSIDECAR-122
> Project: Sidecar for Apache Cassandra
> Issue Type: Bug
> Components: Configuration
> Reporter: Jon Haddad
> Assignee: Francisco Guerrero
> Priority: Normal
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> In the CassandraSidecarDaemon, it loads a default yaml like this:
> {noformat}
> String yamlConfigurationPath = System.getProperty("sidecar.config",
> "file://./conf/config.yaml");
> {noformat}
> but that config file doesn't exist in the distribution.
> {noformat}
> $ ls conf
> logback.xml sidecar.yaml
> {noformat}
> That file doesn't exist in the repository.
> We should pick a default name and have it be consistent.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
