[
https://issues.apache.org/jira/browse/CASSANDRA-18111?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17904424#comment-17904424
]
Stefan Miklosovic commented on CASSANDRA-18111:
-----------------------------------------------
[CASSANDRA-18111|https://github.com/instaclustr/cassandra/tree/CASSANDRA-18111]
{noformat}
java17_pre-commit_tests
✓ j17_build 4m 11s
✓ j17_cqlsh_dtests_py311 7m 25s
✓ j17_cqlsh_dtests_py311_vnode 7m 41s
✓ j17_cqlsh_dtests_py38 6m 48s
✓ j17_cqlsh_dtests_py38_vnode 7m 21s
✓ j17_cqlshlib_cython_tests 10m 50s
✓ j17_cqlshlib_tests 6m 47s
✓ j17_dtests 32m 10s
✓ j17_dtests_vnode 34m 45s
✓ j17_unit_tests 15m 35s
✓ j17_utests_latest 16m 49s
✕ j17_dtests_latest 36m 1s
configuration_test.TestConfiguration test_change_durable_writes
✕ j17_jvm_dtests 26m 0s
junit.framework.TestSuite
org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest
✕ j17_jvm_dtests_latest_vnode 26m 43s
junit.framework.TestSuite
org.apache.cassandra.fuzz.harry.integration.model.InJVMTokenAwareExecutorTest
org.apache.cassandra.distributed.test.tcm.CMSPlacementAfterMoveTest
testMoveToCMS
✕ j17_utests_oa 15m 26s
org.apache.cassandra.db.compaction.CompactionStrategyManagerTest
testAutomaticUpgradeConcurrency
{noformat}
[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5095/workflows/0e357511-3f90-4b4a-9f11-c11cbe6e0a3d]
> Centralize all snapshot operations to SnapshotManager and cache snapshots
> -------------------------------------------------------------------------
>
> Key: CASSANDRA-18111
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18111
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: Local/Snapshots
> Reporter: Paulo Motta
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 5.x
>
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
> Everytime {{nodetool listsnapshots}} is called, all data directories are
> scanned to find snapshots, what is inefficient.
> For example, fetching the
> {{org.apache.cassandra.metrics:type=ColumnFamily,name=SnapshotsSize}} metric
> can take half a second (CASSANDRA-13338).
> This improvement will also allow snapshots to be efficiently queried via
> virtual tables (CASSANDRA-18102).
> In order to do this, we should:
> a) load all snapshots from disk during initialization
> b) keep a collection of snapshots on {{SnapshotManager}}
> c) update the snapshots collection anytime a new snapshot is taken or cleared
> d) detect when a snapshot is manually removed from disk.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
