Stefan Miklosovic created CASSANDRA-20149:
---------------------------------------------

             Summary: nodetool listsnapshots initiates two jmx calls 
unnecessarily
                 Key: CASSANDRA-20149
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20149
             Project: Apache Cassandra
          Issue Type: Improvement
            Reporter: Stefan Miklosovic
            Assignee: Stefan Miklosovic


listsnapshots calls jmx on two occasions

1) when getting trueSnapshotsSize
2) when getting snapshot details

What it was doing in practice before CASSANDRA-18111 was that it was 
essentially loading the snapshots twice hence almost double the time to list.

What is doing after CASSANDRA-18111 is that it still resolves sizes but in a 
way more efficient way however it still calls jmx twice which is not necessary.

The fix consists of returning resolved sizes together with snapshot details and 
then on the client size we just display and sum it up in case of wanting to 
know the total. 

It is way more faster to just return results in one response and sum few 
numbers on the client from the results then to call jmx twice. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to