[
https://issues.apache.org/jira/browse/CASSANDRA-12742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17909349#comment-17909349
]
Maxim Muzafarov commented on CASSANDRA-12742:
---------------------------------------------
[~mck] We have two places where we actually parse the input arguments for the
nodetool - nodetool shell script and the java cli.
When the --ssl flag is present in the tool's input the SSL_ENABLED
(ssl.enabled=true) env is set to configure the connection. So if we only add an
ssl option to the commands themselves (the current patch), the flag won't
change anything and would be used just for the help message, which is wrong.
From my point of view, we have to move the flag processing and usage from shell
to the java side, to the NodeTool class (read properties from
nodetool-ssl.properties and set envs accordingly).
This makes the problem real and it can be implemented independently, before or
after the CASSANDRA-17445 . With the new input from CASSANDRA-11695
CASSANDRA-18508 we can also consider a broader scope and pass the ssl config as
an input to the commands.
> Nodetool --ssl flag is not listed in 'nodetool help'
> ----------------------------------------------------
>
> Key: CASSANDRA-12742
> URL: https://issues.apache.org/jira/browse/CASSANDRA-12742
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Tool/nodetool
> Reporter: Simon Fontana Oscarsson
> Assignee: Anthony Grasso
> Priority: Low
> Fix For: 2.2.x
>
> Attachments: CASSANDRA-12742
>
>
> Nodetool help should show ssl flag as an option.
> Output from "nodetool help" before:
> usage: nodetool [(-pw <password> | --password <password>)]
> [(-pwf <passwordFilePath> | --password-file <passwordFilePath>)]
> [(-p <port> | --port <port>)] [(-h <host> | --host <host>)]
> [(-u <username> | --username <username>)] <command> [<args>]
> After:
> usage: nodetool [(-pw <password> | --password <password>)] [--ssl]
> [(-pwf <passwordFilePath> | --password-file <passwordFilePath>)]
> [(-p <port> | --port <port>)] [(-h <host> | --host <host>)]
> [(-u <username> | --username <username>)] <command> [<args>]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
