[
https://issues.apache.org/jira/browse/CASSANDRA-19947?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913304#comment-17913304
]
Dmitry Konstantinov commented on CASSANDRA-19947:
-------------------------------------------------
Thank you for the report sharing! Few comments:
* I think it would be more beneficial to focus on writes (as I got the patch
does not affect in any way read flow) and do not run reads
* it makes sense to run max throughput test - it is easer to compare than
latency when we speak about processing overheads
* 2500 TPS probably is quite small load for Cassandra to assess the impact
I will try to run a test as well (similar to the test I use in CASSANDRA-20165)
and share the results too. As of now my main interest is to avoid possible
performance impact for write flow when no constraints defined. Unfortunately it
is quite common story when each feature adds some logic with a small overhead
but finally in total we can quite significant impact for a release.
I would recommend to make fast paths in the logic if there are no constraints
defined. As I see in the MR there is already such logic in many places but I
think we can make it cheaper, for example: if we do not have Cell-level
constraints - it is better to just avoid iteration over cells and do not check
every individual one if it has a constraint. Such kind of iterations over cells
is typical overhead case.
> CEP-42: Constraints Framework
> -----------------------------
>
> Key: CASSANDRA-19947
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19947
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: CQL/Syntax
> Reporter: Bernardo Botella
> Assignee: Bernardo Botella
> Priority: Normal
> Attachments: ci_summary.html
>
> Time Spent: 22.5h
> Remaining Estimate: 0h
>
> Add new Constraints framework as described in CEP-42. This initial Jira
> ticket includes the core constraints length and numeric. Follow up tickets
> will include the rest of the constraints described in the CEP.
>
> [https://cwiki.apache.org/confluence/display/CASSANDRA/CEP-42%3A+Constraints+Framework]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
