[ 
https://issues.apache.org/jira/browse/CASSANDRA-20209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17913858#comment-17913858
 ] 

Stefan Miklosovic commented on CASSANDRA-20209:
-----------------------------------------------

[CASSANDRA-20209|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20209]
{noformat}
java17_pre-commit_tests                         
  ✓ j17_build                                        5m 18s
  ✓ j17_cqlsh_dtests_py311                           6m 49s
  ✓ j17_cqlsh_dtests_py311_vnode                     7m 19s
  ✓ j17_cqlsh_dtests_py38                            7m 15s
  ✓ j17_cqlsh_dtests_py38_vnode                       8m 7s
  ✓ j17_cqlshlib_cython_tests                       11m 23s
  ✓ j17_cqlshlib_tests                               8m 17s
  ✓ j17_unit_tests                                  15m 31s
  ✓ j17_unit_tests_repeat                            6m 12s
  ✓ j17_utests_latest                               14m 55s
  ✓ j17_utests_latest_repeat                         5m 33s
  ✓ j17_utests_oa                                    16m 2s
  ✓ j17_utests_oa_repeat                              6m 1s
  ✕ j17_dtests                                      37m 18s
      compaction_test.TestCompaction test_compaction_throughput
      refresh_test.TestRefresh test_refresh_deadlock_startup
  ✕ j17_dtests_latest                               40m 47s
      read_repair_test.TestSpeculativeReadRepair test_failed_read_repair
      read_repair_test.TestSpeculativeReadRepair test_speculative_write
  ✕ j17_dtests_vnode                                40m 28s
      compaction_test.TestCompaction test_compaction_throughput
  ✕ j17_jvm_dtests                                   26m 3s
      org.apache.cassandra.distributed.test.ReadSpeculationTest speculateTest
      
org.apache.cassandra.fuzz.harry.integration.model.ConcurrentQuiescentCheckerIntegrationTest
 testConcurrentReadWriteWorkload
  ✕ j17_jvm_dtests_latest_vnode                     24m 32s
      org.apache.cassandra.distributed.test.jmx.JMXFeatureTest 
testOneNetworkInterfaceProvisioning
{noformat}

[java17_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5208/workflows/b0317fbe-5ab9-4f0b-97e3-47c6b8352aa5]


> Two snapshot manifests on same table against same SSTables do not have always 
> same size
> ---------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-20209
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20209
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Local/Snapshots
>            Reporter: Stefan Miklosovic
>            Assignee: Stefan Miklosovic
>            Priority: Normal
>             Fix For: 5.x
>
>
> I noticed that two manifests can have different sizes when snapshot is 
> created on same SSTables. This might be hit in practice in tests when I 
> measure that two snapshots have same sizes on disk.
> The difference is caused by manifest.json, check these two:
> {code}
> {
>   "files" : [ "oa-1-big-Data.db" ],
>   "created_at" : "2025-01-15T13:26:45.04Z",
>   "expires_at" : null,
>   "ephemeral" : false
> }
> {code}
> {code}
> {
>   "files" : [ "oa-1-big-Data.db" ],
>   "created_at" : "2025-01-15T13:27:45.012Z",
>   "expires_at" : null,
>   "ephemeral" : false
> }
> {code}
> The difference is in "created_at". One manifest has two decimals for 
> milliseconds (04) and another one three (012).
> The difference is one digit, which will make the whole file bigger, hence 
> their sizes do not match, hence the sizes of the snapshots as such do not 
> match.
> This causes errors when e.g. running multiplex tests in CI. If test happens 
> to generate two manifests with three places for milliseconds (or two) in both 
> cases, then it will just pass but every now and then, it doesn't.
> The solution is to modify JsonUtils and persuade JSON_OBJECT_MAPPER to 
> serialize Instant's always with 3 decimal places.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to