[
https://issues.apache.org/jira/browse/CASSANDRA-20208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17914348#comment-17914348
]
Stefan Miklosovic commented on CASSANDRA-20208:
-----------------------------------------------
[CASSANDRA-20208-4.1|https://github.com/instaclustr/cassandra/tree/CASSANDRA-20208-4.1]
{noformat}
java11_pre-commit_tests
✓ j11_build 1m 52s
✓ j11_cqlsh_dtests_py311 5m 51s
✓ j11_cqlsh_dtests_py311_vnode 5m 52s
✓ j11_cqlsh_dtests_py38 5m 37s
✓ j11_cqlsh_dtests_py38_vnode 8m 53s
✓ j11_cqlsh_dtests_py3_vnode 5m 32s
✓ j11_cqlshlib_cython_tests 7m 23s
✓ j11_cqlshlib_tests 6m 9s
✓ j11_dtests_vnode 40m 43s
✓ j11_jvm_dtests 14m 59s
✓ j11_jvm_dtests_vnode 13m 55s
✓ j11_unit_tests 10m 18s
✕ j11_cqlsh_dtests_py3 7m 25s
cqlsh_tests.test_cqlsh_copy.TestCqlshCopy
test_bulk_round_trip_with_timeouts
✕ j11_dtests 53m 14s
refresh_test.TestRefresh test_refresh_deadlock_startup{noformat}
[java11_pre-commit_tests|https://app.circleci.com/pipelines/github/instaclustr/cassandra/5227/workflows/8310709e-ef75-4fd2-bcc3-1de5f8a6e863]
> audit_logging_options parameters are not sanitized when loaded from a
> configuration file on startup
> ---------------------------------------------------------------------------------------------------
>
> Key: CASSANDRA-20208
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20208
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Observability/Logging
> Reporter: Dmitry Konstantinov
> Assignee: Stefan Miklosovic
> Priority: Normal
> Fix For: 4.1.x, 5.0.x, 5.x
>
> Attachments: audit_filtering_state.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> based on the discussion in
> [https://lists.apache.org/thread/3whc30bqfcr1vgwv73zwlv74l2v3c0gt]
> a configuration like this:
> {code:java}
> audit_logging_options:
> enabled: true
> logger:
> - class_name: FileAuditLogger
> included_categories: DCL, ERROR, AUTH {code}
> is not sanitized when it is loaded on startup from cassandra.yaml file -
> spaces here are remaining: " ERROR", " AUTH" after parsing. As a result the
> audit logs filtering works not in a way as a user may expect and it is hard
> to troubleshoot:
> !audit_filtering_state.png|width=400!
> When we run nodetool enableauditlog the following logic is invoked:
> [https://github.com/apache/cassandra/blob/cassandra-4.1.7/src/java/org/apache/cassandra/service/StorageService.java#L6459]
> which rebuild AuditLogOptions using builder API.AuditLogOption.build() has
> sanitisation logic which does the trimming:
> [https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/audit/AuditLogOptions.java#L235]
>
> org.apache.cassandra.config.Config#audit_logging_options is created a generic
> reflective code which does not use the builder, so there is no trimming
> during a startup.
> It can be fixed by adding sanitisation during the startup parsing too to make
> the behaviour more consistent and less error prone.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
