joao-r-reis commented on issue #357: URL: https://github.com/apache/cassandra-gocql-driver/issues/357#issuecomment-2624854138
> I'm concerned about making them return a copy because the only time you call those methods is after the session is created. If it returns a copy then do you need to close the old session? it also means unnecessary connections if you only want 1 session. I was thinking of shallow copying so you would still keep the same connections with the new session but it might become confusing for users to decide which session object they should close and when... > Can we instead change NewSession to accept a SessionConfig that has a ClusterConfig inside of it? Then we can add fields to SessionConfig for whatever we need to set and remove the setter methods. You would still have to use a mutex to manage reading and writing these fields right? The main goal of this issue was to get rid of this mutex. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
