jberragan commented on code in PR #98: URL: https://github.com/apache/cassandra-analytics/pull/98#discussion_r1945271575
########## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/sparksql/filters/PartitionKeyFilter.java: ########## @@ -33,7 +33,7 @@ import org.apache.cassandra.spark.utils.ByteBufferUtils; import org.jetbrains.annotations.NotNull; -public final class PartitionKeyFilter implements Serializable +public final class PartitionKeyFilter implements Serializable, Comparable<PartitionKeyFilter> Review Comment: The `filter` method is unused. I added Comparable so we can sort the partition key filters in token order. I think I intended to improve `ReaderUtils.primaryIndexContainsAnyKey` to permit an improved 'any match' using the sorted order instead of performing an `anyMatch` on each filter, but I didn't get around to it in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
