[
https://issues.apache.org/jira/browse/CASSANDRA-20298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17924975#comment-17924975
]
Dmitry Konstantinov edited comment on CASSANDRA-20298 at 2/7/25 5:59 PM:
-------------------------------------------------------------------------
in non-test code we have the following places in 5.0 which invokes
ColumnFamilyStore#dumpMemtable:
* org.apache.cassandra.db.ColumnFamilyStore#truncateBlocking(boolean) - here
we have FBUtilities.waitOnFuture
* org.apache.cassandra.db.view.TableViews#dumpMemtables - here we do not have
FBUtilities.waitOnFuture but the only place which invokes
TableViews#dumpMemtables is ColumnFamilyStore#truncateBlocking and we use
FBUtilities.waitOnFuture on the main table dump just after it (+
postFlushExecutor is sequential)
* org.apache.cassandra.db.ColumnFamilyStore#unloadCf - here we have
FBUtilities.waitOnFuture
So, such massive future creation does not look like a common scenario to test
intentionally => one more reason to use
FBUtilities.waitOnFuture(cfs.dumpMemtable());
was (Author: dnk):
in non-test code we have the following places in 5.0 which invokes
ColumnFamilyStore#dumpMemtable:
* org.apache.cassandra.db.ColumnFamilyStore#truncateBlocking(boolean) - here
we have FBUtilities.waitOnFuture
* org.apache.cassandra.db.view.TableViews#dumpMemtables - here we do not have
FBUtilities.waitOnFuture but the only place which invokes
TableViews#dumpMemtables is ColumnFamilyStore#truncateBlocking and we use
FBUtilities.waitOnFuture on the main table dump just after it
* org.apache.cassandra.db.ColumnFamilyStore#unloadCf - here we have
FBUtilities.waitOnFuture
So, such massive future creation does not look like a common scenario to test
intentionally => one more reason to use
FBUtilities.waitOnFuture(cfs.dumpMemtable());
> Test failure CommitLogCQLTest.testSwitchMemtable
> ------------------------------------------------
>
> Key: CASSANDRA-20298
> URL: https://issues.apache.org/jira/browse/CASSANDRA-20298
> Project: Apache Cassandra
> Issue Type: Bug
> Components: Local/Commit Log
> Reporter: Brandon Williams
> Assignee: Dmitry Konstantinov
> Priority: Normal
> Fix For: 5.0.x
>
> Attachments:
> TEST-org.apache.cassandra.db.commitlog.CommitLogCQLTest.log,
> TEST-org.apache.cassandra.db.commitlog.CommitLogCQLTest.xml, steps.log
>
>
> Seen here:
> https://app.circleci.com/pipelines/github/driftx/cassandra/1831/workflows/0de1611d-d409-4d15-8171-dcf7183a8c61/jobs/112290/tests
> {noformat}
> unit.framework.AssertionFailedError: Forked Java VM exited abnormally. Please
> note the time in the report does not reflect the time until the VM exit.
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1365)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.util.Vector.forEach(Vector.java:1365)
> at jdk.internal.reflect.GeneratedMethodAccessor4.invoke(Unknown Source)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
