[
https://issues.apache.org/jira/browse/CASSSIDECAR-209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17926572#comment-17926572
]
Doug Rohrer commented on CASSSIDECAR-209:
-----------------------------------------
Thanks for the review - fixed the indents in Server.java, just going to wait
for CI to complete again because I'm paranoid:
[https://app.circleci.com/pipelines/github/JeetKunDoug/cassandra-sidecar/126/workflows/8e0ca96b-61a7-43f9-a5b2-f4c35f3d28ea]
> HealthCheckPeriodicTask leak in Sidecar
> ---------------------------------------
>
> Key: CASSSIDECAR-209
> URL: https://issues.apache.org/jira/browse/CASSSIDECAR-209
> Project: Sidecar for Apache Cassandra
> Issue Type: Task
> Components: Rest API
> Reporter: Doug Rohrer
> Assignee: Doug Rohrer
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
> In an attempt to stop the health check tasks once the server process is
> shutting down, {{HealthCheckPeriodicTask}} registers a listener on the event
> bus every time it is scheduled to unschedule itself. However, this handler
> only needs to be added once, not every time the task is scheduled. We should
> register it when we create the HealthCheckPeriodicTask, not every time it
> runs.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
