jberragan commented on code in PR #93:
URL:
https://github.com/apache/cassandra-analytics/pull/93#discussion_r1956258793
##########
cassandra-analytics-core/src/main/java/org/apache/cassandra/spark/data/CassandraDataLayer.java:
##########
@@ -338,11 +338,13 @@ else if (clearSnapshotStrategy.hasTTL())
private CompletionStage<Map<String, AvailabilityHint>>
createSnapshot(ClientConfig options, RingResponse ring)
{
Map<String, PartitionedDataLayer.AvailabilityHint> availabilityHints =
new ConcurrentHashMap<>(ring.size());
+ Map<String, Boolean> uniqueInstances = new HashMap<>();
Review Comment:
I would be tempted to add an option to the ClientConfig to enable disable
the feature, something like `createSnapshotFilterUniqueInstances`. Default to
`true` is fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
