[
https://issues.apache.org/jira/browse/CASSANDRA-19956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17927596#comment-17927596
]
Brad Schoening commented on CASSANDRA-19956:
--------------------------------------------
[~pedro_gordo] I've tested the changes and they appear to work fine.
group_tokens() iterates over the tokens and skips empty ones. What about
moving that behavior to cql_massage_tokens() instead.
This would seem more direct, easier to follow and is a one line change:
{quote}{{if t[0] == 'endtoken':}}
{{ term_on_nl = False}}
{{ # skip empty statements}}
{{ if len(curstmt) > 1:}}
{{ output.extend(curstmt)}}
{{ curstmt = []}}{quote}
> Do not fail cqlsh when empty statement is parsed
> ------------------------------------------------
>
> Key: CASSANDRA-19956
> URL: https://issues.apache.org/jira/browse/CASSANDRA-19956
> Project: Apache Cassandra
> Issue Type: Improvement
> Components: CQL/Interpreter
> Reporter: Stefan Miklosovic
> Assignee: Pedro Gordo
> Priority: Low
> Fix For: 5.x
>
> Attachments: cqlshlib_tests.txt
>
>
> This really irritates me.
> {code:java}
> cqlsh> select * from ks.tb;;
> ... the result ...
> SyntaxException: line 1:0 no viable alternative at input ';' ([;]){code}
> The second ";" should not matter. It is same way e.g. in Java. When I do
> {code:java}
> int a = 5;;;;;;;; {code}
> This is just perfectly legal. Indeed, more than one ";" is redundant, but it
> still compiles.
> We should do same for CQL.
> {code:java}
> cqlsh> select * from ks.tb;;;;;;;;; {code}
> This should not fail.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
