jberragan commented on code in PR #102:
URL:
https://github.com/apache/cassandra-analytics/pull/102#discussion_r1990340830
##########
cassandra-four-zero-types/build.gradle:
##########
@@ -33,6 +33,7 @@ dependencies {
compileOnly project(":cassandra-analytics-common")
compileOnly(project(path: ':cassandra-four-zero', configuration: 'shadow'))
compileOnly "com.esotericsoftware:kryo-shaded:${kryoVersion}"
+ compileOnly(group: "${sparkGroupId}", name:
"spark-core_${scalaMajorVersion}", version:
"${project.rootProject.sparkVersion}")
Review Comment:
Could you not pull in Spark here? I think you can work around by moving your
`CalendarIntervalSerializer` class to `SparkDuration` and performing the
conversion in `toSparkSqlType`. An effort was made last year to decouple the
types from Spark, so bulk reads can be performed outside of Spark and also
because CDC does not necessarily run in Spark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org
