frankgh commented on code in PR #108:
URL:
https://github.com/apache/cassandra-analytics/pull/108#discussion_r2085055083
##########
cassandra-analytics-core/build.gradle:
##########
@@ -77,8 +77,7 @@ dependencies {
runtimeOnly(group: 'net.java.dev.jna', name: 'jna', version:
"${jnaVersion}")
runtimeOnly(group: 'net.java.dev.jna', name: 'jna-platform', version:
"${jnaVersion}")
- // This dependency must be built by running `scripts/build-dependencies.sh`
- api(group: "${sidecarClientGroup}", name: "${sidecarClientName}", version:
"${sidecarVersion}")
Review Comment:
there's clean up to be done for these variables. I see it in the profiles +
settings.gradle. It'd be useful to clean that up as part of this PR, since we
are removing usage of them here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
