skoppu22 commented on code in PR #109: URL: https://github.com/apache/cassandra-analytics/pull/109#discussion_r2095787453
########## cassandra-analytics-common/src/main/java/org/apache/cassandra/spark/data/CqlTable.java: ########## @@ -242,6 +246,31 @@ public int indexCount() return indexCount; } + /** + * Check each column of the table for UDT type somewhere nested inside it and maintain map of true/false accordingly + * @return map of column name to true/false + */ + private Map<String, Boolean> determineColumnsWithUdts() + { + Map<String, Boolean> columnsWithUdts = new HashMap<>(); + for (Map.Entry<String, CqlField> field : fieldsMap.entrySet()) + { + columnsWithUdts.put(field.getKey(), !(field.getValue().type().udts().isEmpty())); + } + + return columnsWithUdts; + } + + /** + * Determines if a column has UDT type somewhere nested inside it + * @param fieldName name of the column + * @return true if the column has UDT type , false otherwise + */ + public boolean containsUdt(String fieldName) Review Comment: We use the word UDT extensively all over the repo. Better to keep the name containsUdt to be inline with remaining code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org