[ 
https://issues.apache.org/jira/browse/CASSSIDECAR-260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17966274#comment-17966274
 ] 

Yuntong Qu commented on CASSSIDECAR-260:
----------------------------------------

does it make sense to have gossip return 503 when gossip is not avaiable? 

> Inconsistent HTTP return code between gossip and native health check
> --------------------------------------------------------------------
>
>                 Key: CASSSIDECAR-260
>                 URL: https://issues.apache.org/jira/browse/CASSSIDECAR-260
>             Project: Sidecar for Apache Cassandra
>          Issue Type: Bug
>            Reporter: Yuntong Qu
>            Priority: Major
>
> Sidecar currently exposes two health-check endpoints:
>  * Gossip health (/api/v1/cassandra/gossip/__health):
>  * 
>  ** Always returns 200, even when the gossip is unhealthy.
>  * Native health (/api/v1/cassandra/native/__health):
>  * 
>  ** Returns 503 when the native protocol is unhealthy.
> We should unify the inconsistency. 
> This is due to the different implementations:
> [https://github.com/apache/cassandra-sidecar/blob/bbae439d16e2d943b950b4c80cbdbfdbb16abe44/server/src/main/java/org/apache/cassandra/sidecar/handlers/CassandraHealthHandler.java#L88]
> [https://github.com/apache/cassandra-sidecar/blob/bbae439d16e2d943b950b4c80cbdbfdbb16abe44/server/src/main/java/org/apache/cassandra/sidecar/handlers/GossipHealthHandler.java#L62]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to