[ 
https://issues.apache.org/jira/browse/CASSANDRA-20670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18008177#comment-18008177
 ] 

David Capwell commented on CASSANDRA-20670:
-------------------------------------------

||Repo||Branch||Parent Branch||SHA||Status||
|https://github.com/dcapwell/cassandra.git|commit_remote_branch/CASSANDRA-20670-cassandra-4.1-9AC3D4AE-3897-4C93-8E79-4EAC3398A529|cassandra-4.1|a55cc66a69b73718d7d395e4b245f6b57241e694|Unstable

Failed Builds:
||Build||Result||Reason||
| jvm11-dtests          | fail | Test 
org.apache.cassandra.distributed.test.NetstatsBootstrapWithoutEntireSSTablesCompressionStreamin
 |
| jvm8-dtests           | fail | Test 
org.apache.cassandra.distributed.test.NetstatsBootstrapWithEntireSSTablesCompressionStreamingTe
 |
| jvm8-utests-long      | fail | Test 
org.apache.cassandra.cql3.ViewLongTest::testExpiredLivenessInfoWithDefaultTTLWithFlush[1]
 faile |
| python-dtests         | fail | Test 
auth_test.TestNetworkAuth::auth_test.py::TestNetworkAuth::test_full_dc_access 
had an error      |
| python-dtests-large   | fail | Test 
replace_address_test.TestReplaceAddress::replace_address_test.py::TestReplaceAddress::test_repl
 |
| python-upgrade-dtests | fail | Test 
upgrade_tests.paging_test.cls::upgrade_tests.py::paging_test::test_single_cell_deletions
 had an |
||Repo||Branch||Parent Branch||SHA||Status||
|https://github.com/dcapwell/cassandra.git|commit_remote_branch/CASSANDRA-20670-cassandra-5.0-9AC3D4AE-3897-4C93-8E79-4EAC3398A529|cassandra-5.0|a8fe5dd248ebe86486f84f3e04f7af68debde8d4|Unstable

Failed Builds:
||Build||Result||Reason||
| checkstyle                  | fail    |                                       
                                                               |
| dependency_check            | fail    | Found 1 vulnerable dependencies       
                                                               |
| python-dtests               | fail    | Test 
bootstrap_test.TestBootstrap::bootstrap_test.py::TestBootstrap::test_shutdown_wiped_node_cannot
 |
| python-upgrade-dtests       | unknown | No test results found                 
                                                               |
| python-upgrade-dtests-large | unknown | No test results found                 
                                                               |
||Repo||Branch||Parent Branch||SHA||Status||
|https://github.com/dcapwell/cassandra.git|commit_remote_branch/CASSANDRA-20670-trunk-9AC3D4AE-3897-4C93-8E79-4EAC3398A529|trunk|385a6fe9b5f83511c1c2444b6da98971e3c7f154|Unstable

Failed Builds:
||Build||Result||Reason||
| checkstyle            | fail |                                                
                                                      |
| dependency_check      | fail | Found 1 vulnerable dependencies                
                                                      |
| jvm-dtest-simulator   | fail | Test 
org.apache.cassandra.simulator.test.AccordHarrySimulationTest::test-cassandra.testtag_IS_UNDEFI
 |
| jvm11-dtests          | fail | Error parsing 
jvm11-dtests/unitTestReports/TESTS-TestSuites.xml 'message'                     
       |
| jvm11-dtests-fuzz     | fail | Test 
org.apache.cassandra.fuzz.topology.JournalGCTest::journalGCTest-_jdk11 failed   
                |
| jvm17-dtests          | fail | Error parsing 
jvm17-dtests/unitTestReports/TESTS-TestSuites.xml 'message'                     
       |
| jvm17-dtests-fuzz     | fail | Test 
org.apache.cassandra.fuzz.topology.AccordBootstrapTest::bootstrapFuzzTest-_jdk17
 failed         |
| jvm17-utests-long     | fail | Test 
org.apache.cassandra.cql3.ViewLongTest::testExpiredLivenessInfoWithDefaultTTLWithFlush[3]-_jdk1
 |
| python-dtests         | fail | Test 
replace_address_test.TestReplaceAddress::replace_address_test.py::TestReplaceAddress::test_fail
 |
| python-upgrade-dtests | fail | Test 
upgrade_tests.cql_tests.TestCQLNodes3RF3_Upgrade_indev_4_0_x_To_indev_trunk::upgrade_tests.py::
 |


> IntrusiveStack.accumulate is not accumulating correctly
> -------------------------------------------------------
>
>                 Key: CASSANDRA-20670
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-20670
>             Project: Apache Cassandra
>          Issue Type: Bug
>          Components: Legacy/Core
>            Reporter: Yuqi Yan
>            Assignee: Yuqi Yan
>            Priority: Normal
>         Attachments: 
> ci_summary-cassandra-4.1-a55cc66a69b73718d7d395e4b245f6b57241e694.html, 
> ci_summary-cassandra-5.0-a8fe5dd248ebe86486f84f3e04f7af68debde8d4.html, 
> ci_summary-trunk-385a6fe9b5f83511c1c2444b6da98971e3c7f154.html, 
> result_details-cassandra-5.0-a8fe5dd248ebe86486f84f3e04f7af68debde8d4.tar.gz, 
> result_details-trunk-385a6fe9b5f83511c1c2444b6da98971e3c7f154.tar.gz
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {code:java}
> protected static <T extends IntrusiveStack<T>> long accumulate(T list, 
> LongAccumulator<T> accumulator, long initialValue)
> {
>     long value = initialValue;
>     while (list != null)
>     {
>         value = accumulator.apply(list, initialValue);
>                                           ^^^
>         list = list.next;
>     }
>     return value;
> } {code}
> Seems we're restarting from the beginning every time when accumulating. This 
> is used in Paxos V2 when aggregating the responses from peers.
> Here we'll always return 1 even there are more than 1 failures returned by 
> peer nodes - hence we'll be never throwing Read/WriteFailureExceptions if we 
> have 3 nodes and using quorum. (failure count will always be 1, poll_size = 
> 3, poll_size - failure = 2 == quorum hence not considered a "failure")
> Added a simple unit test around FailureRecordingCallback to reproduce this



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org
For additional commands, e-mail: commits-h...@cassandra.apache.org

Reply via email to