anderoo commented on PR #93: URL: https://github.com/apache/cassandra-analytics/pull/93#issuecomment-3094406641
@liucao-dd I see the concern here, especially with the disjointReplica assumption. I'll get a PR together and ensure test coverage for multiple vnodes. I'm not entirely sure I understand the recommendation of "look up which token is owned by which physical node using information from List<Instance>, and construct subRanges accordingly." - I was initially thinking of creating the maximum subRanges from the adjacent token in the list. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscr...@cassandra.apache.org For additional commands, e-mail: commits-h...@cassandra.apache.org
